`gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3 #36775

mkoeppe · 2023-11-26T04:38:49Z

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

mkoeppe · 2023-11-26T18:28:48Z

  [gmp-6.3.0]   OSError: [Errno socket error] [Errno 110] Connection timed out
  [gmp-6.3.0]   
  [gmp-6.3.0]   During handling of the above exception, another exception occurred:
  [gmp-6.3.0]   
  [gmp-6.3.0]   Traceback (most recent call last):
  [gmp-6.3.0]     File "/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 126, in run_safe
  [gmp-6.3.0]       run()
  [gmp-6.3.0]     File "/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 108, in run
  [gmp-6.3.0]       app.download_tarball(args.url_or_tarball, args.destination, args.allow_upstream)
  [gmp-6.3.0]     File "/sage/build/bin/../sage_bootstrap/download/app.py", line 41, in download_tarball
  [gmp-6.3.0]       tarball.download(allow_upstream=allow_upstream)
  [gmp-6.3.0]     File "/sage/build/bin/../sage_bootstrap/tarball.py", line 180, in download
  [gmp-6.3.0]       raise FileNotMirroredError('tarball does not exist on mirror network and neither at the upstream URL')
  [gmp-6.3.0]   sage_bootstrap.tarball.FileNotMirroredError: tarball does not exist on mirror network and neither at the upstream URL
  [gmp-6.3.0]   ************************************************************************
  [gmp-6.3.0]   ************************************************************************
  [gmp-6.3.0]   Error downloading gmp-6.3.0.tar.xz
  [gmp-6.3.0]   ************************************************************************

mkoeppe · 2023-12-13T21:01:19Z

Because of the active countermeasures of gmplib.org, I've added the tarball as a release asset to https://github.com/sagemath/sage/releases/tag/10.2

mkoeppe · 2023-12-14T19:25:58Z

rebased

dimpase · 2023-12-14T19:32:15Z

Because of the active countermeasures of gmplib.org, I've added the tarball as a release asset to https://github.com/sagemath/sage/releases/tag/10.2

so there is now a place tarballs are looked for? Any rules for that (i.e. are tags ignored) ?

mkoeppe · 2023-12-14T19:34:01Z

see https://github.com/sagemath/sage/blob/develop/.upstream.d/20-github.com-sagemath-sage-releases

mkoeppe · 2023-12-14T19:36:49Z

(You reviewed #36435, which added this.)

dimpase · 2023-12-16T09:45:47Z

ModuleNotFoundError: No module named 'sage.libs.coxeter3.coxeter' in Test all files

and quite a few failing tests due to it

is this a known error by now? I saw it elsewhere.

mkoeppe · 2023-12-16T23:54:39Z

ModuleNotFoundError: No module named 'sage.libs.coxeter3.coxeter' in Test all files

and quite a few failing tests due to it

Fixed in #36900

…math#29386 The Cython modules depending on optional packages (such as sage.libs.coxeter3) were not being built after sagemath#29386. This showed up in the CI as numerous doctest failures; as reported in sagemath#36775 (comment) Fixed here by avoiding a clash of environment variables that prevented the function `is_package_installed_and_updated` from functioning during the build of sagelib.      ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#36900 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik

dimpase

lgtm

mkoeppe · 2023-12-17T22:24:55Z

Thanks.

The unreleased 2.2.x series has work on support for Python 3.12 https://github.com/aleaxit/gmpy The new version makes it necessary to tighten the requirements for MPC and MPFR. We do the version check without pkg-config as before; changing it to pkg-config is sagemath#31348.   ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies  - Depends on sagemath#36775 (merged here)  URL: sagemath#36351 Reported by: Matthias Köppe Reviewer(s):

### 📝 Checklist     - [ ] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#36775 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik

vbraun · 2023-12-24T11:06:21Z

I'm getting lots of testsuite fails on OSX around signs of NaN from the gmpy2 testsuite

[gmpy2-2.1.2] **********************************************************************
[gmpy2-2.1.2] File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.11.1/var/tmp/sage/build/gmpy2-2.1.2/src/test/test_mpz.txt", line 515, in test_mpz.txt
[gmpy2-2.1.2] Failed example:
[gmpy2-2.1.2]     divmod(mpfr('nan'), a)
[gmpy2-2.1.2] Differences (ndiff with -expected +actual):
[gmpy2-2.1.2]     - (mpfr('nan'), mpfr('nan'))
[gmpy2-2.1.2]     + (mpfr('-nan'), mpfr('-nan'))
[gmpy2-2.1.2]     ?        +             +
[gmpy2-2.1.2] **********************************************************************
[gmpy2-2.1.2] File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.11.1/var/tmp/sage/build/gmpy2-2.1.2/src/test/test_mpz.txt", line 519, in test_mpz.txt
[gmpy2-2.1.2] Failed example:
[gmpy2-2.1.2]     divmod(mpfr('Inf'), G.mpz(0))
[gmpy2-2.1.2] Differences (ndiff with -expected +actual):
[gmpy2-2.1.2]     - (mpfr('nan'), mpfr('nan'))
[gmpy2-2.1.2]     + (mpfr('nan'), mpfr('-nan'))
[gmpy2-2.1.2]     ?                     +
[gmpy2-2.1.2] **********************************************************************
[gmpy2-2.1.2] File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.11.1/var/tmp/sage/build/gmpy2-2.1.2/src/test/test_mpz.txt", line 523, in test_mpz.txt
[gmpy2-2.1.2] Failed example:
[gmpy2-2.1.2]     divmod(mpfr('nan'), G.mpz(0))
[gmpy2-2.1.2] Differences (ndiff with -expected +actual):
[gmpy2-2.1.2]     - (mpfr('nan'), mpfr('nan'))
[gmpy2-2.1.2]     + (mpfr('-nan'), mpfr('-nan'))
[gmpy2-2.1.2]     ?        +             +
[gmpy2-2.1.2] **********************************************************************
[gmpy2-2.1.2] 1 items had failures:
[gmpy2-2.1.2]   25 of 230 in test_mpz.txt
[gmpy2-2.1.2] ***Test Failed*** 25 failures.
[gmpy2-2.1.2] Results for:  test_mpz                  Attempted:  230   Failed:   25
[gmpy2-2.1.2] Results for:  test_mpz_create           Attempted:   58   Failed:    0
[gmpy2-2.1.2] Results for:  test_mpz_io               Attempted:   60   Failed:    0
[gmpy2-2.1.2] Results for:  test_mpz_pack_unpack      Attempted:   16   Failed:    0
[gmpy2-2.1.2] 
[gmpy2-2.1.2]                               Summary - Attempted: 3556   Failed:   95
[gmpy2-2.1.2] 
[gmpy2-2.1.2] Running external test programs.
[gmpy2-2.1.2] Running test_pack.py                    successful
[gmpy2-2.1.2] Running test_mpz_args.py                successful
[gmpy2-2.1.2] 
[gmpy2-2.1.2] real	0m1.418s
[gmpy2-2.1.2] user	0m1.349s
[gmpy2-2.1.2] sys	0m0.049s
[gmpy2-2.1.2] ************************************************************************
[gmpy2-2.1.2] Error testing package gmpy2-2.1.2
[gmpy2-2.1.2] ************************************************************************

github-actions · 2023-12-26T18:05:34Z

Documentation preview for this PR (built with commit cd3ac16; changes) is ready! 🎉

mkoeppe · 2023-12-31T23:24:44Z

I see these test failures in the gmpy2 tests also when just using the homebrew packages (same versions), which our configure scripts already accepts

mkoeppe · 2023-12-31T23:27:46Z

I'll close this PR in favor of doing these upgrades as part of:

gmp 6.3.0, mpc 1.3.1, mpfr 4.2.1, mpfrcx 0.6.3, gmpy2 2.2.0a1 #36351

…6.3, `gmpy2` 2.2.0a1    The unreleased 2.2.x series has work on support for Python 3.12 https://github.com/aleaxit/gmpy The new version makes it necessary to tighten the requirements for MPC and MPFR. We do the version check without pkg-config as before; changing it to pkg-config is sagemath#31348. (The upgrade of the packages was previously done in sagemath#36775, but has now been merged here.)   ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#36351 Reported by: Matthias Köppe Reviewer(s):

mkoeppe added the c: packages: standard label Nov 26, 2023

mkoeppe self-assigned this Nov 26, 2023

mkoeppe force-pushed the gmp_iml_mpfi_mpfr_mpfrcx branch from 08d9a00 to 5218969 Compare December 13, 2023 20:59

mkoeppe changed the title ~~gmp 6.3.0, mpfr 4.2.1, mpfrcx 0.6.3~~ gmp 6.3.0, mpc 1.3.1, mpfr 4.2.1, mpfrcx 0.6.3 Dec 13, 2023

mkoeppe added the s: needs review label Dec 14, 2023

mkoeppe force-pushed the gmp_iml_mpfi_mpfr_mpfrcx branch from 5218969 to fd11046 Compare December 14, 2023 19:25

dimpase added s: positive review and removed s: needs review labels Dec 17, 2023

dimpase approved these changes Dec 17, 2023

View reviewed changes

vbraun added the s: needs work label Dec 24, 2023

Matthias Koeppe added 4 commits December 26, 2023 09:23

build/pkgs/gmp: Update to 6.3.0

d1e2510

build/pkgs/mpfr: Update to 4.2.1

f789c54

build/pkgs/mpfrcx: Update to 0.6.3

0132a7b

build/pkgs/mpc: Update to 1.3.1

cd3ac16

mkoeppe force-pushed the gmp_iml_mpfi_mpfr_mpfrcx branch from fd11046 to cd3ac16 Compare December 26, 2023 17:24

mkoeppe closed this Dec 31, 2023

github-actions bot removed s: positive review s: needs work labels Dec 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3 #36775

`gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3 #36775

mkoeppe commented Nov 26, 2023

mkoeppe commented Nov 26, 2023

mkoeppe commented Dec 13, 2023

mkoeppe commented Dec 14, 2023

dimpase commented Dec 14, 2023

mkoeppe commented Dec 14, 2023

mkoeppe commented Dec 14, 2023

dimpase commented Dec 16, 2023

mkoeppe commented Dec 16, 2023

dimpase left a comment

mkoeppe commented Dec 17, 2023

vbraun commented Dec 24, 2023

github-actions bot commented Dec 26, 2023

mkoeppe commented Dec 31, 2023

mkoeppe commented Dec 31, 2023 •

edited

Loading

gmp 6.3.0, mpc 1.3.1, mpfr 4.2.1, mpfrcx 0.6.3 #36775

gmp 6.3.0, mpc 1.3.1, mpfr 4.2.1, mpfrcx 0.6.3 #36775

Conversation

mkoeppe commented Nov 26, 2023

📝 Checklist

⌛ Dependencies

mkoeppe commented Nov 26, 2023

mkoeppe commented Dec 13, 2023

mkoeppe commented Dec 14, 2023

dimpase commented Dec 14, 2023

mkoeppe commented Dec 14, 2023

mkoeppe commented Dec 14, 2023

dimpase commented Dec 16, 2023

mkoeppe commented Dec 16, 2023

dimpase left a comment

Choose a reason for hiding this comment

mkoeppe commented Dec 17, 2023

vbraun commented Dec 24, 2023

github-actions bot commented Dec 26, 2023

mkoeppe commented Dec 31, 2023

mkoeppe commented Dec 31, 2023 • edited Loading

`gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3 #36775

`gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3 #36775

mkoeppe commented Dec 31, 2023 •

edited

Loading