Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of computing columns of matrices over GF(2) #38152

Merged
merged 3 commits into from
Jun 9, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions src/sage/matrix/matrix_mod2_dense.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,47 @@ cdef class Matrix_mod2_dense(matrix_dense.Matrix_dense): # dense or sparse
mzd_submatrix(z._entries, self._entries, i, 0, i+1, self._ncols)
return z

def columns(self, copy=True):
"""
Return list of the columns of self.

INPUT:

- ``copy`` - (default: True) if True, return a copy so you can
GiacomoPope marked this conversation as resolved.
Show resolved Hide resolved
modify it safely

EXAMPLES:

An example with a small 3x3 matrix::

sage: M2 = Matrix(GF(2), [[1, 0, 0], [0, 1, 0], [0, 1, 1]])
sage: M2.columns()
[(1, 0, 0), (0, 1, 1), (0, 0, 1)]

GiacomoPope marked this conversation as resolved.
Show resolved Hide resolved
"""
x = self.fetch('columns')
if x is not None:
if copy: return list(x)
return x
cdef Py_ssize_t i

# Note: due to the way M4ri represents values, extracting rows
# is fast, but columns are slow. Therefore we transpose
# then take rows. For more information, see the issue
# https://github.com/sagemath/sage/issues/38150
C = self.transpose().rows()

# Make the vectors immutable since we are caching them
for x in C:
x.set_immutable()

# cache result
self.cache('columns', C)
if copy:
return list(C)
else:
return C
GiacomoPope marked this conversation as resolved.
Show resolved Hide resolved

########################################################################
# LEVEL 2 functionality
# * def _pickle
Expand Down
Loading