build/pkgs/tdlib: Update to 0.9.3
#38163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
June 2, 2024 22:50
…-linux-incremental.yml)
…container if nothing to be tested
…of the default platform (ubuntu-jammy)
…dora-38 by latest
…t from build.yml, use ptest-nodoc to avoid duplicate doc-html build
…e new .git file at the end
mkoeppe
added
c: packages: optional
c: graphics
c: graph theory
and removed
c: graphics
labels
mkoeppe
changed the title
build/pkgs/tdlib: Update to 0.9.2build/pkgs/tdlib: Update to 0.9.1
|
with boost_cropped from SPKG: https://gitlab.com/freetdi/treedec/-/blob/develop/configure.ac?ref_type=heads#L136 |
|
@felix-salfelder with boost from homebrew, boost_system is found but: |
|
I am not sure what -mt is, and why the plain one is missing. Are they interchangeable? The cython bindings should not require boost_thread. Consider removing the test from configure. |
|
Do you think we can also get rid of |
|
Wait, is this whole thing header-only? |
|
On Thu, Jun 06, 2024 at 06:30:23PM -0700, Matthias Köppe wrote:
Do you think we can also get rid of `boost_system`?
Yes. Probably configure should succeed regardless, and tdecomp
compilation should be made conditional on the check.
tdlib should build/link/work either way, please try.
I'll look closer and do the changes when I find the time.
|
|
@dimpase is right that we are missing a text showing that the issue is fixed (#38159 (comment)). |
2 tasks
|
Update PRs are not in charge of adding such tests |
|
Just open a PR for adding this. |
|
I've removed the claim regarding #38159 from the PR description. |
|
It appears that there is disagreement over whether this "needs work" or not. I understand that @dimpase has outlined his points in the comments in #38192 and #38190. It appears to me that this is a "disputed" PR now. So, let me record a -1 for @dimpase. (Please reach out to me if that's not what you had in mind.) |
saraedum
added
disputed
dimpase
added
s: positive review
and removed
disputed
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - FIxes sagemath#30813 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#38144 (merged here for testing) URL: sagemath#38163 Reported by: Matthias Köppe Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
This will fix sagemath#38159 Add a missing test ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ x] The title is concise and informative. - [ x] The description explains in detail what this PR is about. - [ x] I have linked a relevant issue or discussion. - [ x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> sagemath#38163 URL: sagemath#38214 Reported by: Dima Pasechnik Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - FIxes sagemath#30813 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#38144 (merged here for testing) URL: sagemath#38163 Reported by: Matthias Köppe Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
This will fix sagemath#38159 Add a missing test ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ x] The title is concise and informative. - [ x] The description explains in detail what this PR is about. - [ x] I have linked a relevant issue or discussion. - [ x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> sagemath#38163 URL: sagemath#38214 Reported by: Dima Pasechnik Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 17, 2024
This will fix sagemath#38159 Add a missing test ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ x] The title is concise and informative. - [ x] The description explains in detail what this PR is about. - [ x] I have linked a relevant issue or discussion. - [ x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> sagemath#38163 URL: sagemath#38214 Reported by: Dima Pasechnik Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies