Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of setup.py bdist_wheel and direct uses of python3 -m build #38201

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 12, 2024

This is the next step in the modernization of our use of build front ends for Python SPKGs, after #35618.

  • New sage-dist-helper functions sdh_build_wheel, sdh_build_and_store_wheel (split out from pkgs/sagemath-doc-{html,pdf} #36730)
  • New option --sdist-then-wheel for sdh_pip_install (and the new sdh_build*wheel functions)

By switching the packages sagemath_environment etc. from direct use of python3 -m build to the sdh_build_and_store_wheel script, it now falls back to --no-build-isolation when building with build isolation fails.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit 0878cc2; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 28, 2024
@vbraun vbraun merged commit 2a67457 into sagemath:develop Jul 4, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sagemath_environment must respect --enable-system-site-packages
3 participants