Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for E302 #38920

Merged
merged 2 commits into from
Dec 8, 2024
Merged

check for E302 #38920

merged 2 commits into from
Dec 8, 2024

Conversation

fchapoton
Copy link
Contributor

this is fixing all remaining warnings about

E302 expected 2 blank lines, found 1

and adding this to the linter.

This was scripted using autopep8.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Nov 4, 2024

Documentation preview for this PR (built with commit b64dcee; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@fchapoton
Copy link
Contributor Author

back to positive after trivial merge

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 6, 2024
    
this is fixing all remaining warnings about

`E302 expected 2 blank lines, found 1`

and adding this to the linter.

This was scripted using `autopep8`.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38920
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Martin Rubey
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 8, 2024
    
this is fixing all remaining warnings about

`E302 expected 2 blank lines, found 1`

and adding this to the linter.

This was scripted using `autopep8`.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38920
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Martin Rubey
@vbraun vbraun merged commit b027ac8 into sagemath:develop Dec 8, 2024
17 of 23 checks passed
@fchapoton fchapoton deleted the activate_check_for_E302 branch December 9, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants