many single-backticks should be double-backticks #38991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 15511a7; changes) is ready! 🎉 |
|
More similar issues can be found using
|
|
indeed, and it seems we have plenty that could also be fixed in this PR... |
|
OK, I'll spend a few minutes to do some more of these. |
DaveWitteMorris
changed the title
|
This PR was originally a trivial edit, but now it's a patchbomb that hits about 60 files. Will we be able to merge it? |
user202729
suggested changes
Nov 19, 2024
src/sage/combinat/crystals/spins.pyx
Outdated
| @@ -108,7 +108,7 @@ def CrystalOfSpinsPlus(ct): | |||
| r""" | |||
| Return the plus spin crystal of the given type D. | |||
|
|
|||
| This is the crystal with highest weight `Lambda_n` (the | |||
| This is the crystal with highest weight `\lambda_n` (the | |||
There was a problem hiding this comment.
The original paper (Crystal Graphs for Representations of the q-Analogue of Classical Lie Algebras
M. Kashiwara, Toshiki Nakashima) uses uppercase Lambda (Λ) for fundamental weight. (Edit the occurrence above too.)
There was a problem hiding this comment.
Thanks for the correction. I made the fix, so is it ok to restore to positive review?
user202729
approved these changes
Nov 19, 2024
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 6, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The docstring of `sage.combinat.posets.posets.FinitePoset` includes: ``` ``elements`` -- an optional list of elements, with ``element[i]`` corresponding to vertex ``i``. If ``elements`` is ``None``, then it is set to be the vertex set of the digraph. Note that if this option is set, then ``elements`` is considered as a specified linear extension of the poset and the `linear_extension` attribute is set. ``` In the last line, this PR changes the single-backticks around `linear_extension` to double-backticks. (Currently, `linear_extension` is typeset as latex math, so it is in italics and the "e" shows up as a subscript.) It also changes about 60 other similar problems. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38991 Reported by: DaveWitteMorris Reviewer(s): DaveWitteMorris, David Coudert, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 8, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The docstring of `sage.combinat.posets.posets.FinitePoset` includes: ``` ``elements`` -- an optional list of elements, with ``element[i]`` corresponding to vertex ``i``. If ``elements`` is ``None``, then it is set to be the vertex set of the digraph. Note that if this option is set, then ``elements`` is considered as a specified linear extension of the poset and the `linear_extension` attribute is set. ``` In the last line, this PR changes the single-backticks around `linear_extension` to double-backticks. (Currently, `linear_extension` is typeset as latex math, so it is in italics and the "e" shows up as a subscript.) It also changes about 60 other similar problems. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38991 Reported by: DaveWitteMorris Reviewer(s): DaveWitteMorris, David Coudert, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docstring of
sage.combinat.posets.posets.FinitePosetincludes:In the last line, this PR changes the single-backticks around
linear_extensionto double-backticks. (Currently,linear_extensionis typeset as latex math, so it is in italics and the "e" shows up as a subscript.)It also changes about 60 other similar problems.
📝 Checklist
⌛ Dependencies