Issue/2641 - mainly cell editable:false support #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le" and "editable" metadata states
…y for dev) and some ideas what to do with that
…k why deleting does not do anything
…nd highlighting it visually
haraldschilly
force-pushed
the
issue/2641
branch
from
82dbf29
to
e986d68
Compare
haraldschilly
force-pushed
the
issue/2641
branch
from
7790166
to
6085551
Compare
… list of protected cell attributes in _set
haraldschilly
force-pushed
the
issue/2641
branch
from
6085551
to
f6612b4
Compare
haraldschilly
force-pushed
the
issue/2641
branch
from
fc37f68
to
315ef20
Compare
williamstein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is for #2641, add a bit of UI and new behavior for {
metadata: editable:false, and/ordeletable:false}upstream fallout: jupyter/notebook#3308, jupyter/notebook#3322 and some discussion jupyter/notebook#2389
and another difference from classical is delete behavior: for range selections, instead of doing nothing, protected cells are kept while the normal ones are deleted.