From bca3fd426da9f6cbea3268900554953390c566cc Mon Sep 17 00:00:00 2001 From: Brian Ridings Date: Mon, 3 Feb 2014 11:33:55 -0500 Subject: [PATCH 1/5] Add CSRF Security measures on login forms just added the csrf middleware --- app.js | 1 + 1 file changed, 1 insertion(+) diff --git a/app.js b/app.js index dbd924acdf..f39b8e6d64 100755 --- a/app.js +++ b/app.js @@ -60,6 +60,7 @@ app.use(require('connect-assets')({ helperContext: app.locals })); app.use(express.compress()); +app.use(express.csrf()); app.use(express.favicon()); app.use(express.logger('dev')); app.use(express.cookieParser()); From c53729d5edc49a8205b6038d32d0a8aaeeed97af Mon Sep 17 00:00:00 2001 From: Brian Ridings Date: Mon, 3 Feb 2014 13:27:06 -0500 Subject: [PATCH 2/5] Removed dynamicHelpers comment --- app.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/app.js b/app.js index 532be844d3..2075c61174 100755 --- a/app.js +++ b/app.js @@ -92,13 +92,6 @@ app.use(function(req, res) { }); app.use(express.errorHandler()); -/*Helper function for CSRF -app.dynamicHelpers({ - token: function(req, res) { - return req.session._csrf; - } -});*/ - /** * Application routes. */ From 5b64ee01cc62734217fed50af6f286e25bf9812a Mon Sep 17 00:00:00 2001 From: Brian Ridings Date: Mon, 3 Feb 2014 13:31:04 -0500 Subject: [PATCH 3/5] Removed extra app.use(express.csrf()); --- app.js | 1 - 1 file changed, 1 deletion(-) diff --git a/app.js b/app.js index 2075c61174..5996534e22 100755 --- a/app.js +++ b/app.js @@ -60,7 +60,6 @@ app.use(require('connect-assets')({ helperContext: app.locals })); app.use(express.compress()); -app.use(express.csrf()); app.use(express.favicon()); app.use(express.logger('dev')); app.use(express.cookieParser()); From 6828e15bfbf5d85f5e62eca57bba25b8ab54450e Mon Sep 17 00:00:00 2001 From: Brian Ridings Date: Mon, 3 Feb 2014 13:31:53 -0500 Subject: [PATCH 4/5] Readded newline --- views/account/profile.jade | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/views/account/profile.jade b/views/account/profile.jade index a47a2eb4c3..2fd987d92a 100644 --- a/views/account/profile.jade +++ b/views/account/profile.jade @@ -85,4 +85,5 @@ block content if user.github p: a.text-danger(href='/account/unlink/github') Unlink your GitHub account else - p: a(href='/auth/github') Link your GitHub account \ No newline at end of file + p: a(href='/auth/github') Link your GitHub account + From dff5aa16abc8af360bc1dc8f7842bde417ee6283 Mon Sep 17 00:00:00 2001 From: Brian Ridings Date: Mon, 3 Feb 2014 13:32:13 -0500 Subject: [PATCH 5/5] Update profile.jade --- views/account/profile.jade | 1 - 1 file changed, 1 deletion(-) diff --git a/views/account/profile.jade b/views/account/profile.jade index 2fd987d92a..3d56e33f65 100644 --- a/views/account/profile.jade +++ b/views/account/profile.jade @@ -86,4 +86,3 @@ block content p: a.text-danger(href='/account/unlink/github') Unlink your GitHub account else p: a(href='/auth/github') Link your GitHub account -