Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly bundle Sailthru Models DLL in Nuget package #78

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

jethrocarr
Copy link
Contributor

With the recent move to use .Net Standard 2.0, we broke the bundling of Sailthru.Models library into the Nuget package.

Correctly including dependencies seems to be a repeat pain point for Nuget as per dotnet/sdk#6688, but the approach added here seem to work and can see the Model now being included in the compiled package

% unzip -l Sailthru.Client.1.2.1.nupkg
Archive:  Sailthru.Client.1.2.1.nupkg
  Length      Date    Time    Name
---------  ---------- -----   ----
      505  12-20-2022 13:59   _rels/.rels
      812  12-20-2022 13:59   Sailthru.Client.nuspec
    30208  12-20-2022 00:21   lib/netstandard2.0/Sailthru.Models.dll <-- was previously missing
    23040  12-20-2022 00:59   lib/netstandard2.0/Sailthru.dll
      459  12-20-2022 13:59   [Content_Types].xml
      644  12-20-2022 13:59   package/services/metadata/core-properties/fae2406158514c48b501b0980e09e4f2.psmdcp
---------                     -------
    55668                     6 files

Additionally Sailthru.Models is no longer a dependency inside Sailthru.Client.nuspec file so once uploaded Nuget should stop trying to reference it as a dependency to download.

Also fixed the license warning for good measure.

@jethrocarr jethrocarr requested a review from mudgeST December 20, 2022 01:04
@jethrocarr jethrocarr self-assigned this Dec 20, 2022
@jethrocarr jethrocarr merged commit d079858 into master Dec 20, 2022
@jethrocarr jethrocarr deleted the build-tweaks branch December 20, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants