Correctly bundle Sailthru Models DLL in Nuget package #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent move to use .Net Standard 2.0, we broke the bundling of Sailthru.Models library into the Nuget package.
Correctly including dependencies seems to be a repeat pain point for Nuget as per dotnet/sdk#6688, but the approach added here seem to work and can see the Model now being included in the compiled package
Additionally Sailthru.Models is no longer a dependency inside
Sailthru.Client.nuspec
file so once uploaded Nuget should stop trying to reference it as a dependency to download.Also fixed the license warning for good measure.