Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node to version 18 #2525

Closed
krzysztofzuraw opened this issue Nov 3, 2022 · 1 comment · Fixed by #2533
Closed

Update node to version 18 #2525

krzysztofzuraw opened this issue Nov 3, 2022 · 1 comment · Fixed by #2533
Assignees
@krzysztofzuraw
Labels
maintenance

Comments

@krzysztofzuraw
Copy link
Member

krzysztofzuraw commented Nov 3, 2022 •
edited
Loading

What needs to be done

  • Update to 18.12.0
  • Update .nvmrc
  • Update GHA workflows to read node version from .nvmrc
  • Update setup-node workflows for GHA to version 3
  • Update the docker node version to 18
@krzysztofzuraw krzysztofzuraw self-assigned this Nov 3, 2022
@krzysztofzuraw krzysztofzuraw moved this to Backlog in Dashboard Nov 3, 2022
@krzysztofzuraw krzysztofzuraw moved this from Backlog to In Progress in Dashboard Nov 3, 2022
@krzysztofzuraw krzysztofzuraw changed the title Update node to version 16 Update node to version 18 Nov 3, 2022
@krzysztofzuraw krzysztofzuraw mentioned this issue Nov 4, 2022
Merged
27 tasks
@krzysztofzuraw krzysztofzuraw moved this from In Progress to In Review in Dashboard Nov 7, 2022
@krzysztofzuraw krzysztofzuraw moved this from In Review to In QA in Dashboard Nov 9, 2022
@karolm-saleor karolm-saleor moved this from In QA to In Progress in Dashboard Nov 15, 2022
@karolm-saleor
Copy link
Contributor

Task rejected from QA.
This changed caused the Cypress config to fail so now we are not able to run the tests locally

Repository owner moved this from In Progress to Done in Dashboard Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzysztofzuraw krzysztofzuraw

Labels
maintenance
Projects
Dashboard
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade node to 18 saleor/saleor-dashboard
2 participants
@krzysztofzuraw @karolm-saleor