Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node to 18 #2533

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Upgrade node to 18 #2533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e85e3f2
wip
krzysztofzuraw Nov 4, 2022
c67fc64
build: add setup node to workflow
krzysztofzuraw Nov 4, 2022
fe3699c
build: test more memory for npm install
krzysztofzuraw Nov 4, 2022
bcea151
build: use node from nvmrc in github workflows
krzysztofzuraw Nov 4, 2022
39909fa
fix: use 18 as version
krzysztofzuraw Nov 9, 2022
5551324
Update e2e.yml
karola312 Nov 10, 2022
7b99a35
build: migrate cypress repeat
krzysztofzuraw Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cypress-repeat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version-file: ".nvmrc"

- name: Install cypress-repeat
run: npm i -D cypress-repeat
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/deploy-and-run-cypress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ jobs:
env: ${{ env.GITHUB_HEAD_REF_SLUG_URL }}
ref: ${{ github.head_ref }}

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: ".nvmrc"

- name: Cache node modules
uses: actions/cache@v2
env:
Expand Down Expand Up @@ -96,9 +101,9 @@ jobs:
uses: actions/checkout@v1

- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: 16
node-version-file: '.nvmrc'

- name: Cypress run critical
uses: cypress-io/github-action@v4
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/deploy-cloud.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ jobs:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.client_payload.ref }}
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: ".nvmrc"
- name: Package
timeout-minutes: 15
run: |
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/deploy-demo-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ jobs:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.inputs.git_ref || '' }}
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: ".nvmrc"
- name: Package
timeout-minutes: 15
run: |
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/deploy-demo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ jobs:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.client_payload.ref }}
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: ".nvmrc"
- name: Package
timeout-minutes: 15
run: |
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/deploy-gcp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ jobs:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.client_payload.ref }}
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: ".nvmrc"
- name: Package
timeout-minutes: 15
run: |
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/deploy-master-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ jobs:
IS_CLOUD_INSTANCE: true
steps:
- uses: actions/checkout@v2

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: ".nvmrc"
- name: Package
timeout-minutes: 15
run: |
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/deploy-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ jobs:
environment=$(echo $VERSION | sed -n 's#\([0-9]\+\).\([0-9]\+\).*#saleor-staging-v\1\2#p')
echo "ENVIRONMENT=${environment}" >> $GITHUB_ENV

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: ".nvmrc"

- name: Package
timeout-minutes: 15
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ jobs:
uses: actions/checkout@v2

- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: 14
node-version-file: '.nvmrc'

- name: Wait for Deploy and tests
uses: lewagon/wait-on-check-action@v1.0.0
Expand All @@ -83,7 +83,7 @@ jobs:
run-tests-in-parallel-on-label:
needs: [get-selected-tags-and-containers, install-cypress]
runs-on: ubuntu-latest
container: cypress/browsers:node14.16.0-chrome89-ff86
container: cypress/browsers:node18.12.0-chrome106-ff106
strategy:
fail-fast: false
max-parallel: 10
Expand Down Expand Up @@ -127,4 +127,4 @@ jobs:
parallel: true
group: 'UI - Chrome'
record: true
tag: e2eTestsOnPR
tag: e2eTestsOnPR
18 changes: 11 additions & 7 deletions .github/workflows/test-env-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ jobs:
base_URL: ${{ steps.set-domain.outputs.domain }}
steps:
- uses: actions/checkout@v2
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: ".nvmrc"

- uses: rlespinasse/github-slug-action@3.1.0

Expand Down Expand Up @@ -165,12 +169,12 @@ jobs:

- name: echo-tags
run: |
echo ${{steps.get_tags.outputs.result}}
echo ${{steps.get_tags.outputs.result}}

cypress-run-selected:
runs-on: ubuntu-latest
needs: [prepare-tests, deploy]
container: cypress/browsers:node14.16.0-chrome89-ff86
container: cypress/browsers:node18.12.0-chrome106-ff106
strategy:
fail-fast: false
max-parallel: 10
Expand All @@ -191,9 +195,9 @@ jobs:
run: |
echo "::set-output name=custom_api_uri::$(echo $pull_request_body | grep -Eo "$prefix$pattern" | sed s/$prefix// | head -n 1 | { read custom_uri; if [ -z "$custom_uri" ]; then echo "$fallback_uri"; else echo "$custom_uri"; fi })"
- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: 14
node-version-file: ".nvmrc"

- name: Cache node modules
uses: actions/cache@v2
Expand All @@ -208,7 +212,7 @@ jobs:
${{ runner.os }}-
- name: Install Dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: npm install
run: NODE_OPTIONS=--max_old_space_size=4096 npm install

- name: Cypress run critical
uses: cypress-io/github-action@v4
Expand All @@ -225,6 +229,6 @@ jobs:
CYPRESS_grepTags: ${{ needs.prepare-tests.outputs.tags }}
with:
parallel: true
group: 'UI - Chrome'
group: "UI - Chrome"
record: true
tag: Critical, ${{github.event.action}}
tag: Critical, ${{github.event.action}}
9 changes: 6 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/setup-node@v3
with:
node-version: '14'
node-version-file: '.nvmrc'
- name: Cache node modules
uses: actions/cache@v2
env:
Expand All @@ -75,7 +75,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version-file: ".nvmrc"
- name: Cache node modules
uses: actions/cache@v2
env:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/tests-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version-file: '.nvmrc'

- name: Install saleor cli
id: install-saleor-cli
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 14
node-version-file: '.nvmrc'

- name: Cypress run
id: cypress
Expand Down Expand Up @@ -161,9 +161,9 @@ jobs:
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: 14
node-version-file: '.nvmrc'

- name: Install dependencies
run: |
Expand Down Expand Up @@ -253,9 +253,9 @@ jobs:
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: 14
node-version-file: '.nvmrc'

- name: Install dependencies
run: |
Expand Down
1 change: 0 additions & 1 deletion .node-version
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
puppeteer_skip_chromium_download = true
puppeteer_skip_chromium_download=true
legacy-peer-deps=true
NyanKiyoshi marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14.19.0
18
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:14 as builder
FROM node:18 as builder
WORKDIR /app
COPY package*.json ./
RUN npm install
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:14
FROM node:18
WORKDIR /app
COPY package*.json ./
RUN npm install
Expand Down
Loading