Update SugarFolders.php Not returning User Accessible inbound accounts (group) #276
Conversation
…s. is_group 2 small bugs: 1) $item->isgroup is not correct. It is not a class but and array and should be retrieved like $item['is_group'] also the name isgroup is incorrect, it should be is_group like in the array. 2) if($isGroup===1) is too restrictive. Should be if ($isGroup == 1) which will return true.
|
|
There was a problem hiding this comment.
This change is no longer necessary, I have incorporated this in a revised retrieveFoldersForProcessing function that includes this fix along with functionality to check if current user is admin and also to filter out group folders that the current user does not have access to. Currently, all group folders show.
There was a problem hiding this comment.
Hi @pstevens71, thank you for the PR and for the update.
I didn't follow 100%.
Does this mean we can close this PR?
There was a problem hiding this comment.
Yes you can close this one. I'm going to enter another one today that includes this change plus a few other things in this particular function to support getting group folders to work properly. I have a whole bunch of changes that together solve the whole problem. Apologies I'm kind of new to Github and don't know how to delete or modify this PR. After I entered it I realized a bunch of other modifications where necessary in addition to this.
|
@pstevens71 thank you. closing according to #276 (comment) |
Just troubleshooting group folders. and found this.
2 small bugs:
Description
$item->isgroup is not correct. It is not a class but and array and should be retrieved like $item['is_group'] also the name isgroup is incorrect, it should be is_group like in the array.
if($isGroup===1) is too restrictive. Should be if ($isGroup == 1) which will return true. (this was an issue in 7.12 too!)
Since Group folders are not working anyway (I'm working on that too! the problem is the JSON returns group folders in a separate array for the folders selections in user profile list, I haven't tested potential impacts of changing this)
Motivation and Context
Trying to get group folders working and usable for users. Currently cannot see or view group folders.
How To Test This
Types of changes
Final checklist