Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #309 - Add help text #316

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

yunusyerli1
Copy link
Contributor

@yunusyerli1 yunusyerli1 commented Aug 18, 2023

Description

In Studio if you populate the 'Help Text' on a field, it's expected that when you hover that field in the Views, you'd see the text you added in Studio. However currently nothing appears to happen. #309

Motivation and Context

After adding help text in studio, and after hovering on related filed, it is expected to see help text as tooltip.

How To Test This

Add help text on a field in Studio and repair and rebuild. Hover on the field on related module on browser.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@chris001
Copy link
Contributor

@yunusyerli1
Very nice.
If you could, it would be great to add also the "?" icon, which exists in many places already in the app, for users on touch interfaces (tablet, phone), which has no ability to "hover", so they could tap on the "?" icon to see this Help text.

<ndc-dynamic
[ndcDynamicComponent]="componentType"
[ndcDynamicInputs]="{
<div [title]="field.definition.help ?? '' ">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yunusyerli1, better to use a <span> instead of a div. Fields can be used inline and in many places, not only on the standard views

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@johnM2401
Copy link

Hey @yunusyerli1, @clemente-raposo

I wanted to get your opinions on something, for this.

While testing this, I'd noticed that the user is not able to see the tooltip on non-edit views, (ie: Detail/List/Modal), if the field has no data.

See attached gif:
hoverOnDetail

I feel this might be worth investigating, to further enhance this.
What are your thoughts?

Thanks!

@johnM2401 johnM2401 added Status:Requires Updates Issues & PRs which requires input or update from the author Status: Passed Testing and removed Status: Requires Testing labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Passed Testing Status: Requires Code Review Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants