Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10520 - Discount Calculation incorrect when changing Currency #10520

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

serhiisamko091184
Copy link
Contributor

Description

If the user changes the currency on a Quote/Invoice, the generated Group Discount is not always correct.
This can be most noted when changing the Discount Amount/Percentage, the Group amount will become wildly incorrect

Motivation and Context

How To Test This

  1. Set another currency.
  2. Create a record in the Quotes/Invoice module.
  3. On Edit View try to change the currency and check the result of the Group Discount field.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 changed the title Fix # - Discount Calculation incorrect when changing Currency Fix #10520 - Discount Calculation incorrect when changing Currency Sep 10, 2024
@johnM2401 johnM2401 added Type: Bug Bugs within the core SuiteCRM codebase Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Severity: Moderate Key function failed, but no or little impact and removed Type: Bug Bugs within the core SuiteCRM codebase Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Severity: Moderate Key function failed, but no or little impact labels Sep 10, 2024
@serhiisamko091184 serhiisamko091184 added Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants