Skip to content

Conversation

@davidlygagnon
Copy link
Contributor

Fixes #1600

Picking up left over work from #1638 where we want to have the new optionsSearchEntity and optionsAddItem working with keyboard navigation (highlighted and actionable).

Additional description

screenshot_keyboard


CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Borys Seiryk and others added 6 commits November 2, 2018 18:07
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 May 19, 2019 06:44 Inactive
@interactivellama
Copy link
Contributor

I think the search entity is supposed to be highlighted on typing. I think that is why it's a new prop. It's allow supposed to update with the input value in the menu item in the example, too.

46897326-27c0ac00-ce3f-11e8-91c9-9f85ca5f4120

@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 June 7, 2019 05:48 Inactive
@davidlygagnon davidlygagnon changed the title Adding header and footer items for combobox. [in progress - do not merge] Adding header and footer items for combobox. Jun 7, 2019
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 2, 2019 14:18 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 2, 2019 17:31 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 2, 2019 17:41 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 2, 2019 18:14 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 2, 2019 18:46 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 3, 2019 13:29 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 3, 2019 14:12 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 3, 2019 14:13 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 3, 2019 14:25 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 15, 2019 15:22 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 15, 2019 16:18 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 15, 2019 23:16 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1986 July 18, 2019 19:04 Inactive
@interactivellama
Copy link
Contributor

@davidlygagnon Is this ready for review?

@interactivellama interactivellama added this to the MC design backlog milestone Jul 22, 2019
@davidlygagnon
Copy link
Contributor Author

@interactivellama Yes - this is ready for review. Thanks.

@davidlygagnon davidlygagnon changed the title [in progress - do not merge] Adding header and footer items for combobox. Adding header and footer items for combobox. Aug 1, 2019
…to combobox_props

# Conflicts:
#	components/combobox/__docs__/site-stories.js
#	package-lock.json
@interactivellama interactivellama merged commit 254fadf into salesforce:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footer and header render in combobox

2 participants