-
Notifications
You must be signed in to change notification settings - Fork 433
Adding header and footer items for combobox. #1986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
interactivellama
merged 33 commits into
salesforce:master
from
davidlygagnon:combobox_props
Aug 24, 2019
Merged
Adding header and footer items for combobox. #1986
interactivellama
merged 33 commits into
salesforce:master
from
davidlygagnon:combobox_props
Aug 24, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support cross-entity - loading - default value - disabled - Menu: Footer and Header
…ctly with focus/keyboard navigation and keyboard enter
Contributor
…tion to string for props.label
Contributor
|
@davidlygagnon Is this ready for review? |
Contributor
Author
|
@interactivellama Yes - this is ready for review. Thanks. |
…to combobox_props # Conflicts: # components/combobox/__docs__/site-stories.js # package-lock.json
18 tasks
Add IsLoading, assistiveText.loading, and update example
…to combobox_props
To make sure header items are selectable
No that snapshot testing is done in Storybook
interactivellama
approved these changes
Aug 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Fixes #1600
Picking up left over work from #1638 where we want to have the new
optionsSearchEntityandoptionsAddItemworking with keyboard navigation (highlighted and actionable).Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fixhas been run and linting passes.components/component-docs.jsonCI tests pass (npm test).REVIEWER checklist (do not remove)
components/component-docs.jsontests.Required only if there are markup / UX changes
last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.