From 739776781bc28929127487e0a2a3bc36afe930fc Mon Sep 17 00:00:00 2001 From: Nicolas Kruk Date: Mon, 3 Feb 2025 18:01:09 -0500 Subject: [PATCH 1/2] fix: local dev logs LWC mismatch warnings on every SSR request --- .../src/framework/check-version-mismatch.ts | 5 +++++ .../rendering/version-mismatch/index.spec.js | 18 ++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/packages/@lwc/engine-core/src/framework/check-version-mismatch.ts b/packages/@lwc/engine-core/src/framework/check-version-mismatch.ts index a8821a5f62..9b555336a2 100644 --- a/packages/@lwc/engine-core/src/framework/check-version-mismatch.ts +++ b/packages/@lwc/engine-core/src/framework/check-version-mismatch.ts @@ -38,6 +38,11 @@ export function checkVersionMismatch( ) { const versionMatcher = func.toString().match(LWC_VERSION_COMMENT_REGEX); if (!isNull(versionMatcher) && !warned) { + if (process.env.SKIP_LWC_VERSION_MISMATCH_CHECK === 'true') { + warned = true; // skip printing out version mismatch errors when env var is set + return; + } + const version = versionMatcher[1]; if (version !== LWC_VERSION) { warned = true; // only warn once to avoid flooding the console diff --git a/packages/@lwc/integration-karma/test/rendering/version-mismatch/index.spec.js b/packages/@lwc/integration-karma/test/rendering/version-mismatch/index.spec.js index a24f0c4701..65ad476fb5 100644 --- a/packages/@lwc/integration-karma/test/rendering/version-mismatch/index.spec.js +++ b/packages/@lwc/integration-karma/test/rendering/version-mismatch/index.spec.js @@ -48,9 +48,27 @@ describe('compiler version mismatch', () => { }); afterEach(() => { + process.env.SKIP_LWC_VERSION_MISMATCH_CHECK = 'false'; detachReportingControlDispatcher(); }); + it('skip warning during local dev', () => { + process.env.SKIP_LWC_VERSION_MISMATCH_CHECK = 'true'; + function tmpl() { + return []; + /*LWC compiler v123.456.789*/ + } + + expect(() => { + registerTemplate(tmpl); + }).not.toLogErrorDev( + new RegExp( + `LWC WARNING: current engine is v${process.env.LWC_VERSION}, but template was compiled with v123.456.789` + ) + ); + expect(dispatcher).not.toHaveBeenCalled(); + }); + it('template', () => { function tmpl() { return []; From d135dbf60e0d4a3e579ce0cf3cac00979d020011 Mon Sep 17 00:00:00 2001 From: Nicolas Kruk Date: Mon, 3 Feb 2025 18:39:22 -0500 Subject: [PATCH 2/2] fix: null checks for safety --- .../@lwc/engine-core/src/framework/check-version-mismatch.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@lwc/engine-core/src/framework/check-version-mismatch.ts b/packages/@lwc/engine-core/src/framework/check-version-mismatch.ts index 9b555336a2..badcdb4f61 100644 --- a/packages/@lwc/engine-core/src/framework/check-version-mismatch.ts +++ b/packages/@lwc/engine-core/src/framework/check-version-mismatch.ts @@ -38,7 +38,7 @@ export function checkVersionMismatch( ) { const versionMatcher = func.toString().match(LWC_VERSION_COMMENT_REGEX); if (!isNull(versionMatcher) && !warned) { - if (process.env.SKIP_LWC_VERSION_MISMATCH_CHECK === 'true') { + if (process?.env?.SKIP_LWC_VERSION_MISMATCH_CHECK === 'true') { warned = true; // skip printing out version mismatch errors when env var is set return; }