From 2b17deff29f446c58c04e554e41d8cb176e4b628 Mon Sep 17 00:00:00 2001 From: mshanemc Date: Tue, 11 Jun 2024 15:22:30 -0500 Subject: [PATCH 1/4] docs: message for custom fields wildcard --- messages/retrieve.start.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/messages/retrieve.start.md b/messages/retrieve.start.md index 88d5990a..5d1db3a6 100644 --- a/messages/retrieve.start.md +++ b/messages/retrieve.start.md @@ -191,7 +191,7 @@ The retrieve target directory [%s] overlaps one of your package directories. Spe # wantsToRetrieveCustomFields -Because you're retrieving one or more CustomFields, we're also retrieving the CustomObject to which it's associated. +Because you're retrieving one or more CustomFields that you didn't specify the name for, we're also retrieving the CustomObject to which it's associated. # noSourceTracking From 0ec508bef8a00570649c1e4637bb23f2ede1421a Mon Sep 17 00:00:00 2001 From: mshanemc Date: Wed, 12 Jun 2024 12:21:25 -0500 Subject: [PATCH 2/4] docs: fix message per PR discussion --- messages/retrieve.start.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/messages/retrieve.start.md b/messages/retrieve.start.md index 5d1db3a6..da04593f 100644 --- a/messages/retrieve.start.md +++ b/messages/retrieve.start.md @@ -191,7 +191,7 @@ The retrieve target directory [%s] overlaps one of your package directories. Spe # wantsToRetrieveCustomFields -Because you're retrieving one or more CustomFields that you didn't specify the name for, we're also retrieving the CustomObject to which it's associated. +Because you're retrieving one or more CustomFields that you didn't specify the name for, we're also retrieving the CustomObject to which they're associated. # noSourceTracking From 3a0b409359187ba3afd937821b1f145fe9764896 Mon Sep 17 00:00:00 2001 From: mshanemc Date: Wed, 12 Jun 2024 12:21:41 -0500 Subject: [PATCH 3/4] refactor: use common table header styler --- src/commands/project/delete/source.ts | 5 ++--- src/formatters/deleteResultFormatter.ts | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/commands/project/delete/source.ts b/src/commands/project/delete/source.ts index be15ef1b..5cc3229c 100644 --- a/src/commands/project/delete/source.ts +++ b/src/commands/project/delete/source.ts @@ -33,10 +33,9 @@ import { requiredOrgFlagWithDeprecations, SfCommand, } from '@salesforce/sf-plugins-core'; -import ansis from 'ansis'; import { writeConflictTable } from '../../../utils/conflicts.js'; import { isNonDecomposedCustomLabel, isNonDecomposedCustomLabelsOrCustomLabel } from '../../../utils/metadataTypes.js'; -import { getFileResponseSuccessProps } from '../../../utils/output.js'; +import { getFileResponseSuccessProps, tableHeader } from '../../../utils/output.js'; import { API, DeleteSourceJson, isFileResponseDeleted, isSdrSuccess, isSourceComponent } from '../../../utils/types.js'; import { getPackageDirs, getSourceApiVersion } from '../../../utils/project.js'; import { resolveApi, validateTests } from '../../../utils/deploy.js'; @@ -187,7 +186,7 @@ export class Source extends SfCommand { if (!this.components.length) { // if we didn't find any components to delete, let the user know and exit - this.styledHeader(ansis.blue('Deleted Source')); + this.styledHeader(tableHeader('Deleted Source')); this.log('No results found'); return; } diff --git a/src/formatters/deleteResultFormatter.ts b/src/formatters/deleteResultFormatter.ts index 88fd741c..09f1ca1c 100644 --- a/src/formatters/deleteResultFormatter.ts +++ b/src/formatters/deleteResultFormatter.ts @@ -7,7 +7,6 @@ import { Ux } from '@salesforce/sf-plugins-core'; import { DeployResult, FileResponse, FileResponseSuccess, RequestStatus } from '@salesforce/source-deploy-retrieve'; import { ensureArray } from '@salesforce/kit'; -import ansis from 'ansis'; import { StandardColors } from '@salesforce/sf-plugins-core'; import { DeleteSourceJson, Formatter, TestLevel, isSdrSuccess } from '../utils/types.js'; import { @@ -15,6 +14,7 @@ import { fileResponseSortFn, getFileResponseSuccessProps, makePathRelative, + tableHeader, } from '../utils/output.js'; import { TestResultsFormatter } from '../formatters/testResultsFormatter.js'; @@ -80,7 +80,7 @@ export class DeleteResultFormatter extends TestResultsFormatter implements Forma } ux.log(''); - ux.styledHeader(ansis.blue('Deleted Source')); + ux.styledHeader(tableHeader('Deleted Source')); ux.table( successes.map(getFileResponseSuccessProps), { From 83d7cedd5a45a712140516573a42f217b26490e2 Mon Sep 17 00:00:00 2001 From: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com> Date: Wed, 12 Jun 2024 10:21:43 -0700 Subject: [PATCH 4/4] Update retrieve.start.md --- messages/retrieve.start.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/messages/retrieve.start.md b/messages/retrieve.start.md index 5d1db3a6..da04593f 100644 --- a/messages/retrieve.start.md +++ b/messages/retrieve.start.md @@ -191,7 +191,7 @@ The retrieve target directory [%s] overlaps one of your package directories. Spe # wantsToRetrieveCustomFields -Because you're retrieving one or more CustomFields that you didn't specify the name for, we're also retrieving the CustomObject to which it's associated. +Because you're retrieving one or more CustomFields that you didn't specify the name for, we're also retrieving the CustomObject to which they're associated. # noSourceTracking