Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating body and replacing with response_body #11

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Sep 5, 2022

Cherry picked from hashicorp/terraform-provider-http#137.

Fixes #10.

Copy link
Owner

@salrashid123 salrashid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thatnks for the PR.

Couple of changes to the test cases. The terraform that a testcase exercises must have a corresponding line of code that checks for it.

you can run the tests using make tests

terraform-provider-http-full$ make test
==> Checking that code complies with gofmt requirements...
go test -i $(go list ./...) || exit 1
go: -i flag is deprecated
echo $(go list ./...) | \
	xargs -t -n4 go test  -timeout=30s -parallel=4
go test '-timeout=30s' '-parallel=4' github.com/salrashid123/terraform-provider-http-full github.com/salrashid123/terraform-provider-http-full/internal/provider
?   	github.com/salrashid123/terraform-provider-http-full	[no test files]
ok  	github.com/salrashid123/terraform-provider-http-full/internal/provider	6.118s

internal/provider/data_source_test.go Show resolved Hide resolved
internal/provider/data_source_test.go Outdated Show resolved Hide resolved
internal/provider/data_source_test.go Outdated Show resolved Hide resolved
internal/provider/data_source_test.go Outdated Show resolved Hide resolved
internal/provider/data_source_test.go Outdated Show resolved Hide resolved
internal/provider/data_source_test.go Outdated Show resolved Hide resolved
internal/provider/data_source_test.go Outdated Show resolved Hide resolved
@orgads
Copy link
Contributor Author

orgads commented Sep 6, 2022

Thank you. The tests pass now.

@salrashid123 salrashid123 merged commit 2de8631 into salrashid123:main Sep 6, 2022
@orgads orgads deleted the response-body branch September 6, 2022 11:22
@salrashid123
Copy link
Owner

thanks, this and the PRs 12,13 included in

terraform {
  required_providers {
    http-full = {
      source = "salrashid123/http-full"
            version = "1.3.1"
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow http and deprecate body in favor of response_body
2 participants