Restrict set_attribute_was patch to Rails versions >= 5.2, < 6 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR attr-encrypted#416 included a patch for ActiveRecord 5.2: priyankatapar@7e8702b
Apparently that change was useful Rails 5.2, but it does not work for Rails 6+. It relies on the
set_attribute_wasmethod, which was removed from Rails in rails/rails#35933.That removal would have been included in 6.0.0.rc1:
https://github.com/rails/rails/blob/6-0-stable/activerecord/CHANGELOG.md#rails-600rc1-april-24-2019
This PR addresses that by using the pessimistic version constraint to limit the patch above to Rails versions >= 5.2, < 6.