fix: vscode extension name cannot be scoped (#823)

* fix: vscode extension name cannot be scoped microsoft/vscode-vsce#186 also: fixed package script to fail on error
salto-io · Mar 15, 2020 · 17d9764 · 17d9764
1 parent 2dcdebd
commit 17d9764
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -242,7 +242,7 @@ jobs:
 
       - run:
           name: Create a VSIX file
-          command: yarn workspace @salto-io/vscode package
+          command: yarn workspace salto-vscode package
 
       - upload_pkg:
           workspace_dir: vscode

diff --git a/packages/vscode/package.json b/packages/vscode/package.json
@@ -1,5 +1,5 @@
 {
-    "name": "@salto-io/vscode",
+    "name": "salto-vscode",
     "displayName": "Salto",
     "description": "Configure Salto patches in vscode.",
     "version": "0.1.11",

diff --git a/packages/vscode/scripts/package.sh b/packages/vscode/scripts/package.sh
@@ -1,9 +1,11 @@
 #!/bin/bash
+set -xeuo pipefail
+
 mkdir -p ./tmp_pkg && vsce package --yarn -o ./tmp_pkg/salto.vsix
-cd ./tmp_pkg && unzip salto.vsix 
-cp -r ../node_modules/* extension/node_modules/ 
-zip -ur salto.vsix extension 
+cd ./tmp_pkg && unzip salto.vsix
+cp -r ../node_modules/* extension/node_modules/
+zip -ur salto.vsix extension
 cd ..
-mkdir -p ./pkg 
-cp ./tmp_pkg/salto.vsix ./pkg/salto.vsix 
-rm -rf ./tmp_pkg
+mkdir -p ./pkg
+cp ./tmp_pkg/salto.vsix ./pkg/salto.vsix
+rm -rf ./tmp_pkg