fix: vscode extension name cannot be scoped #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft/vscode-vsce#186 also: fixed package script to fail on error
erikzaadi
reviewed
Mar 15, 2020
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "@salto-io/vscode", | |||
| "name": "salto-vscode", | |||
There was a problem hiding this comment.
@hadard notice that you commented on this the last time as well, it can't be under the org using the @ token since it borks up the extensions build script
Codecov Report
@@ Coverage Diff @@
## master #823 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 208 208
Lines 9359 9359
Branches 1670 1670
=======================================
Hits 8577 8577
Misses 782 782
Continue to review full report at Codecov.
|
roironn
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/vscode-vsce#186
also: fixed package script to fail on error