Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for minion "master" parameter does not work #27

Closed
tmandry opened this issue Mar 11, 2014 · 4 comments
Closed

Default value for minion "master" parameter does not work #27

tmandry opened this issue Mar 11, 2014 · 4 comments

Comments

@tmandry
Copy link

tmandry commented Mar 11, 2014

When the master is also being configured. The problem is this line in salt/files/minion:

{{ get_config('master', 'salt') }}

If pillars['salt']['minion']['master'] does not exist, it will try pillars['salt']['master'], which of course is itself a dict.

@TimJones
Copy link

TimJones commented Jul 8, 2014

I am having the same issue. A temporary workaround is to provide an explicit master config for the minion template in the pillar:

salt:
  minion:
    master: salt
  master:
    ...

It's hacky but works until we can get a proper fix.

@blast-hardcheese
Copy link
Contributor

fwiw, this workaround doesn't seem to work for me anymore (salt-master 2015.5.5 (Lithium)):

salt:
  minion:
    - master: salt
  master:
    fileserver_backend:
      - git
      - roots
    gitfs_provider: pygit2
    gitfs_remotes:
      - https://github.com/saltstack-formulas/salt-formula
[root@ip-172-31-52-196 srv]# salt-call pillar.get salt:master
local:
    ----------
    fileserver_backend:
        - git
        - roots
    gitfs_provider:
        pygit2
    gitfs_remotes:
        - https://github.com/saltstack-formulas/salt-formula

@blast-hardcheese
Copy link
Contributor

This should be resolved as of #179

@gravyboat
Copy link
Contributor

Thanks @blast-hardcheese, if this is not resolved please comment on this issue and we can reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants