Improved support for Enterprise Linux family OSs (CentOS, RHEL etc) #139
Conversation
* Install pygit from package * Add Official Salt ZeroMQ 4 COPR repository Note that Salt itself is assumed to already to be available to the system via yum, via EPEL for example
Improved support for Enterprise Linux family OSs (CentOS, RHEL etc)
| include: | ||
| - .{{ grains['os']|lower }} | ||
| {% endif %} | ||
| - .{{ name }} |
There was a problem hiding this comment.
You probably could have just changed grains['os']|lower to grains['os_family']|lower
There was a problem hiding this comment.
Nevermind, I didn't realize there was already stuff for not just Debian there.
|
@mattwillsher did the master config part in map.jinja work on rhel/centos? |
|
Now you mention it, no I think it got left unset. I can take a look tomorrow. From memory, it being unset meant that pygit2 got used as it was available. What is it it you see? That when gitpython is set it gets left as it is rather that replaced by pygit? From: Niels Abspoel <notifications@github.commailto:notifications@github.com> @mattwillsherhttps://github.com/mattwillsher did the master config part in map.jinja work on rhel/centos? Reply to this email directly or view it on GitHubhttps://github.com//pull/139#issuecomment-109557991. |
|
You have set the map.jinja redhat default master: gitfs_provider: pygit2, What I would think that should happen is that the f_defaults.conf picks this up and uses the parameter. |
|
pygit2 is the default in any case. map.jinja is currently only used by the formula itself as you point out. While I agree the value should be set in the f_defaults, this has never been the case for the formula, if I understand correctly. Perhaps this is better opened as an issue and tracked via that? |
Note that Salt itself is assumed to already to be available to the system via yum, via EPEL for example