Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes saltstack-formulas/salt-formula#190 #250

Merged
merged 2 commits into from
Sep 13, 2016
Merged

Fixes saltstack-formulas/salt-formula#190 #250

merged 2 commits into from
Sep 13, 2016

Conversation

luitzifa
Copy link

@luitzifa luitzifa commented Sep 5, 2016

No description provided.

@gravyboat gravyboat merged commit ad440d9 into saltstack-formulas:master Sep 13, 2016
@wwentland
Copy link
Contributor

wwentland commented Sep 13, 2016

Not trying to criticise the work, but can't we use https://docs.saltstack.com/en/latest/ref/modules/all/salt.modules.defaults.html#salt.modules.defaults.merge here?

@luitzifa
Copy link
Author

@BABILEN you are totally right! It's definitely the better choice here.
I didn't know about this module but i gave it a try and it worked well.
See: #252

@wwentland
Copy link
Contributor

Wonderful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants