adding salt-minion restart option from official FAQ page

[mechleg]

I have run into an issue similar to those described in #136 . I was hoping to find a different solution then the one recently merged, mostly to not have another package dependency.

I found such a solution here, using the "bg" option in cmd.run:
https://docs.saltstack.com/en/latest/faq.html#what-is-the-best-way-to-restart-a-salt-minion-daemon-using-salt-after-upgrade

This has been working on all my Linux minions better then the salt-minion restart method used in the current formula. It should also work on Windows though I am not able to test that.

This PR changes the current default salt-minion restart behavior to that described in the linked FAQ. It should be backward compatible and add similar functionality to salt versions without the "bg" option.

Thoughts? Good idea? Bad idea?

[aboe76]

@tlemarchand could you take a look to?

[javierbertoli]

It LGTM, although I have no Windows box to test the Windows parts.

[aboe76]

@mechleg can you confirm this works on windows? @javierbertoli and I don't have a setup with windows minions.

[mechleg]

Unfortunately, neither do I, Linux only shop over here.

I figured since it was on the FAQ, someone tested those commands in Windows at some point. If no one uses this formula with Windows, I could take those bits out.

[aboe76]

@mechleg and @javierbertoli because this is behind a switch I think it's safe to merge and if some windows minion user is complaining we can fix it then.

[mechleg]

Sounds good to me, anything else I need to do?

[aboe76]

@mechleg no, just need a confirmation from @javierbertoli then I merged it.

[javierbertoli]

@aboe76, I think it's ok to merge.

[aboe76]

@mechleg and @javierbertoli thanks for this. hopefully it will help others.