Quotation and ipv6 #355
Merged
Quotation and ipv6 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
t0fik
commented
Jan 11, 2018
t0fik
commented
- I've added quotation in file_ignore_glob. Lack of quotation was causing pase error.
- some cleanup in template, to make compiled file looks nicer.
|
Since IPv6 commit was reverted you should just squash it. As for quotation, you really should split that commit out of the changes regarding newlines/spaces stripping as it makes it hard to see what was changed exactly. |
t0fik
force-pushed
the
quotation_and_ipv6
branch
from
657f9e6
to
45bde07
Compare
ixs
pushed a commit
to bawuenet/salt-formula
that referenced
this pull request
Jul 22, 2018
* Added quotration around globing rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.