Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lay the ground work for integration with travis-ci.org #13

Merged
merged 7 commits into from
Feb 15, 2017

Conversation

fintanmm
Copy link

Hi all,

What this PR does, is to introduce testing for this formula. Each state within this formula has it's corresponding instance created using travis-ci. The dependencies for this formula are cloned and made available to each instance. The kitchen file contains the necessary pillar data for creating each WordPress site including the db, vhost, etc...
The tests take about 3 to 4 minutes a piece but I think it's worth it.

Let me know what you think.

Regards,
Fintan

@aboe76 aboe76 merged commit 8148099 into saltstack-formulas:master Feb 15, 2017
@aboe76
Copy link
Member

aboe76 commented Feb 15, 2017

thanks for this.

@blbradley
Copy link

Howdy! I've done this technique with several formulas. So, I'll chime in.

kitchen-salt bootstraps a Docker container with Salt, as you probably know. It looks like you are covering many different OSes. Travis CI can be much slower than your laptop or workstation. So, the tests will take more time than you have measured. Travis quits displaying output after 30 minutes and stops running with failure after 50 minutes.

When you start covering more cases, it is likely you will need to optimize the container bootstrap process. I've started this process here and here. Feel free to join or ask me any questions about testing Salt formulas.

@fintanmm
Copy link
Author

Hi @blbradley,

Thanks for the tip, I'll be following this with interest as I other formulas that I want to contribute to.

Regards,
Fintan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants