Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drone CI: which configuration file is in use and how to update it properly? #1395

Closed
vutny opened this issue Nov 27, 2019 · 1 comment · Fixed by #1424
Closed

Drone CI: which configuration file is in use and how to update it properly? #1395

vutny opened this issue Nov 27, 2019 · 1 comment · Fixed by #1424

Comments

@vutny
Copy link
Contributor

vutny commented Nov 27, 2019

Description of Issue/Question

This is a question: which file serves as a source of configuration for Drone CI,
.drone.yml or .drone.jsonnet?
If some of it is legacy, we need to drop it to avoid confusion and duplication of efforts. If the one of it is somehow generated from the other one, it should be documented how to make this conversion.

Also it appears that after the changes was made to the CI configs, all subsequent builds require manual approval from authorized person to kick off the build.

@s0undt3ch, could we change the CI behavior somehow to allow config changes applied automatically once being propagated to the develop? Because for now the build for the tip of develop is stuck:
https://drone.saltstack.com/saltstack/salt-bootstrap/282

@s0undt3ch
Copy link
Contributor

.drone.jsonnet is used to generate .drone.yml

#1396 fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants