Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or deprecate heat module and keystone state module to work with new keystoneng module #55611

Closed
Ch3LL opened this issue Dec 11, 2019 · 4 comments
Assignees
Labels
Bug broken, incorrect, or confusing behavior Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Deprecation severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@Ch3LL
Copy link
Contributor

Ch3LL commented Dec 11, 2019

Description of Issue

This issue #49419 was setup to track deprecating the keystone module in salt/modules/keystone.py in favor of salt/modules.keystoneng.py. The problem is there are a couple other files that use this module that still need to either be deprecated or updated to work with the new keystoneng module.

For now I am going to push the deprecation warning out to a later release and use this issue to track setting these other modules on a deprecation path or updating them to use the new keystoneng module. The modules that still call salt/modules/keystone are:

  • salt/states/keystone.py
  • salt/modules/heat.py

glance module also calls the keystone module but the glance module is already set on a deprecation path itself for its own module.

@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P3 Priority 3 team-core labels Dec 11, 2019
@Ch3LL Ch3LL added this to the Approved milestone Dec 11, 2019
@Ch3LL Ch3LL added the ZRelease-Sodium retired label label Dec 11, 2019
@stale
Copy link

stale bot commented Jan 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 12, 2020
@sagetherage sagetherage added the Confirmed Salt engineer has confirmed bug/feature - often including a MCVE label Jan 17, 2020
@stale
Copy link

stale bot commented Jan 17, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 17, 2020
@sagetherage sagetherage assigned waynew and unassigned Ch3LL May 5, 2020
@waynew waynew added Magnesium Mg release after Na prior to Al and removed ZRelease-Sodium retired label labels May 18, 2020
@waynew
Copy link
Contributor

waynew commented May 18, 2020

pushing this (once again) to Magnesium

@sagetherage sagetherage removed the P3 Priority 3 label Jun 3, 2020
@sagetherage sagetherage removed this from the Approved milestone Jul 14, 2020
@sagetherage
Copy link
Contributor

closing this issue in favor of linked issue

@sagetherage sagetherage removed the Magnesium Mg release after Na prior to Al label Jul 27, 2020
@sagetherage sagetherage modified the milestones: Magnesium, Approved Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Deprecation severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

3 participants