Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PendingDeprecationWarning #51262

Closed
wants to merge 7 commits into from
Closed

Remove PendingDeprecationWarning #51262

wants to merge 7 commits into from

Conversation

jynolen
Copy link
Contributor

@jynolen jynolen commented Jan 21, 2019

What does this PR do?

It avoid future deprecated function

What issues does this PR fix or reference?

None (except pytest's testinfra warning issue)

Tests written?

No

Commits signed with GPG?

No

@jynolen jynolen requested a review from a team as a code owner January 21, 2019 14:54
@chenull chenull mentioned this pull request Jan 30, 2019
Closed
@dwoz
Copy link
Contributor

dwoz commented Jan 30, 2019

This should resolve #51398

terminalmage
terminalmage approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@terminalmage terminalmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require a backport. Do we know where this popped up the first time? Was it just in the RC?

@terminalmage terminalmage added the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Jan 30, 2019
@s0undt3ch
Copy link
Collaborator

This looks good though extra care must be taken to make sure we don't break communication compatibility with older masters .

@garethgreenaway
Copy link
Contributor

This should also resolve #51666

@Oloremo
Copy link
Contributor

Oloremo commented Feb 26, 2019

Looking forward for this to be merged.

@waynew
Copy link
Contributor

waynew commented Feb 26, 2019

FWIW, the raw keyword doesn't exist in older distributions of msgpack, which is why some of those builds are failing. Will we have dropped support for those older versions by the time develop is released?

@s0undt3ch
Copy link
Collaborator

A simple try/except TypeError falling back to the old kwargs might be enough to maintain compat with older versions.

@waynew
Copy link
Contributor

waynew commented Mar 22, 2019

FWIW, encoding='utf-8' is found in test/integration/init.py

Not sure if there are any other places we would want to fix this.

@waynew waynew self-assigned this Mar 10, 2020
@waynew waynew self-requested a review March 10, 2020 22:12
@waynew waynew removed their assignment Mar 10, 2020
@waynew
Copy link
Contributor

waynew commented Mar 10, 2020

I'm pretty sure that this has been solved by #55354

@waynew waynew closed this Mar 10, 2020
@cmcmarrow cmcmarrow mentioned this pull request May 21, 2021
Closed
@cmcmarrow cmcmarrow mentioned this pull request Aug 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terminalmage terminalmage terminalmage approved these changes

@s0undt3ch s0undt3ch Awaiting requested review from s0undt3ch

@waynew waynew Awaiting requested review from waynew

Assignees
No one assigned
Labels
bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch Reviewers-Assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jynolen @dwoz @s0undt3ch @garethgreenaway @Oloremo @waynew @terminalmage @Ch3LL