[2018.3] Fixes to dns_check in salt.utils.network #51297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….ext.ipaddress.IPv4Address or an salt.ext.ipaddress.IPv6Address object, just return the exploded IP address.
Ch3LL
added
bugfix-bckport
thatch45
approved these changes
Jan 24, 2019
s0undt3ch
reviewed
Jan 24, 2019
|
@s0undt3ch I was still seeing the issue even after pulling in the changes from that PR you referenced. |
|
Really?! Weird. So this should still be considered being merged right? |
|
@s0undt3ch Let me double it again. |
|
@s0undt3ch It looks like is working as expected now, I think the dns_check test is valuable though so I'll update the PR to just include the test. |
|
👍 |
Ch3LL
removed
the
bugfix-bckport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Inside the dns_check function if the master address is either an salt.ext.ipaddress.IPv4Address or an salt.ext.ipaddress.IPv6Address object, just return the exploded IP address.
What issues does this PR fix or reference?
#51289
Previous Behavior
Specifying an IP address as the Salt master would result in the Salt minion being unable to start.
New Behavior
Salt minion starts.
Tests written?
Yes
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.