From 2ac0ccd26b34d8123e0f7a5e0c9bdc7a8cde540e Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Tue, 15 Aug 2023 18:47:05 +0530 Subject: [PATCH 1/5] go.mod: Bump Go version to 1.19 Signed-off-by: Anoop C S --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 66684a4f..9966b3f1 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/samba-in-kubernetes/samba-operator -go 1.18 +go 1.19 require ( github.com/go-logr/logr v1.2.3 From daaf2b4a14153b1a1a820ae32162a2c4eced8a65 Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Tue, 15 Aug 2023 19:12:57 +0530 Subject: [PATCH 2/5] Dockerfile: Update base golang image to 1.19 Signed-off-by: Anoop C S --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 737e3de9..11115088 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ # Build the manager binary -FROM docker.io/golang:1.18 as builder +FROM docker.io/golang:1.19 as builder ARG GIT_VERSION="(unset)" ARG COMMIT_ID="(unset)" ARG ARCH="" From 73b9cabe71fc0c68f7284e90582359c48dfa43dc Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Tue, 15 Aug 2023 18:45:13 +0530 Subject: [PATCH 3/5] github: Update setup-go action with Go 1.19 Signed-off-by: Anoop C S --- .github/workflows/main.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 75cc9bd3..7a86ede4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -13,7 +13,7 @@ jobs: steps: - uses: actions/setup-go@v3 with: - go-version: "1.18" + go-version: "1.19" - uses: actions/checkout@v3 - name: Build run: make @@ -23,7 +23,7 @@ jobs: steps: - uses: actions/setup-go@v3 with: - go-version: "1.18" + go-version: "1.19" - uses: actions/checkout@v3 - name: Install revive run: go install github.com/mgechev/revive@latest @@ -46,7 +46,7 @@ jobs: steps: - uses: actions/setup-go@v3 with: - go-version: "1.18" + go-version: "1.19" - uses: actions/checkout@v3 - name: run the tests run: make test @@ -100,7 +100,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 with: - go-version: "1.18" + go-version: "1.19" - name: Install k3d run: curl -L --silent --fail "https://raw.githubusercontent.com/rancher/k3d/main/install.sh" | bash # The TAG env var can interfere with the k3d install script. From 8ed23476c2e6f1a66ca4d2f00e45dbf62780215b Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Tue, 15 Aug 2023 18:47:27 +0530 Subject: [PATCH 4/5] tests/centosci: Update mirrored golang image to 1.19 Signed-off-by: Anoop C S --- tests/centosci/sink-clustered-deployment.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/centosci/sink-clustered-deployment.sh b/tests/centosci/sink-clustered-deployment.sh index c5a2249f..37c9b0f0 100755 --- a/tests/centosci/sink-clustered-deployment.sh +++ b/tests/centosci/sink-clustered-deployment.sh @@ -13,7 +13,7 @@ setup_minikube deploy_rook -image_pull "${CI_IMG_REGISTRY}" "docker.io" "golang:1.18" +image_pull "${CI_IMG_REGISTRY}" "docker.io" "golang:1.19" # Build and push operator image to local CI registry IMG="${CI_IMG_OP}" make image-build From 2794f743ea56a33fc2137317e649d75fc1e2d7bd Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Tue, 15 Aug 2023 18:45:53 +0530 Subject: [PATCH 5/5] docs: Update Go version references to 1.19 Signed-off-by: Anoop C S --- docs/CONTRIBUTING.md | 2 +- docs/developers-notes.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 80dcd1ca..64f47d9f 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -17,7 +17,7 @@ resources. Development effort takes place using Linux environment and requires at minimum: -1. [Go 1.18](https://golang.org/dl/) installed +1. [Go 1.19](https://golang.org/dl/) installed 2. [GitHub](https://github.com/) account 3. Development tools: git, make, and podman or docker 4. Testing: [minikube](https://minikube.sigs.k8s.io) diff --git a/docs/developers-notes.md b/docs/developers-notes.md index f2abb24c..c038a99c 100644 --- a/docs/developers-notes.md +++ b/docs/developers-notes.md @@ -4,7 +4,7 @@ ## Build from source The top-level [Makefile](../Makefile) is the entry point for various build -commands. The minimal required Go version is 1.18. A developer can verify the +commands. The minimal required Go version is 1.19. A developer can verify the build environment by running: ```bash