Add First and FirstOrZeroValue functions #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alireza-Kiani
changed the title
|
To follow the go conventions, I would return To follow the samber/lo convention, I would replace "zero" with "empty" in naming. func First[T]([]T) T
func FirstOrEmpty[T]([]T) T
func FirstOr[T]([]T, T) TWDYT ? |
|
I agree. Also, why doesn't FirstOrZero depends on First ? |
…n and add FirstOr
|
Hey guys, thanks for your replies. @samber You are right, the initial changes did not follow conventions properly, Updated the implementation according to your saying. @ccoVeille Good point, I made a change to the implementation and right now other functions rely on the base |
samber
approved these changes
Jun 27, 2024
github-actions bot
referenced
this pull request
in kairos-io/provider-kairos
Jun 28, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.41.0` -> `v1.42.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.42.0`](https://togithub.com/samber/lo/releases/tag/v1.42.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.41.0...v1.42.0) #### What's Changed - feat: add Nil by [@​gubtos](https://togithub.com/gubtos) in [https://github.com/samber/lo/pull/383](https://togithub.com/samber/lo/pull/383) - feat: Add First and FirstOrZeroValue functions by [@​Alireza-Kiani](https://togithub.com/Alireza-Kiani) in [https://github.com/samber/lo/pull/451](https://togithub.com/samber/lo/pull/451) - feat: adding LastOrEmpty and LastOr by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/474](https://togithub.com/samber/lo/pull/474) - feat: Feature/contains iterate by index by [@​lennon-guan](https://togithub.com/lennon-guan) in [https://github.com/samber/lo/pull/428](https://togithub.com/samber/lo/pull/428) - feat: speed up loops by reducing allocations by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/475](https://togithub.com/samber/lo/pull/475) - doc: inconsistent expression in README.md by [@​rolancia](https://togithub.com/rolancia) in [https://github.com/samber/lo/pull/406](https://togithub.com/samber/lo/pull/406) #### New Contributors - [@​gubtos](https://togithub.com/gubtos) made their first contribution in [https://github.com/samber/lo/pull/383](https://togithub.com/samber/lo/pull/383) - [@​Alireza-Kiani](https://togithub.com/Alireza-Kiani) made their first contribution in [https://github.com/samber/lo/pull/451](https://togithub.com/samber/lo/pull/451) - [@​rolancia](https://togithub.com/rolancia) made their first contribution in [https://github.com/samber/lo/pull/406](https://togithub.com/samber/lo/pull/406) - [@​lennon-guan](https://togithub.com/lennon-guan) made their first contribution in [https://github.com/samber/lo/pull/428](https://togithub.com/samber/lo/pull/428) **Full Changelog**: samber/lo@v1.41.0...v1.42.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jul 2, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.39.0` -> `v1.44.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.44.0`](https://togithub.com/samber/lo/releases/tag/v1.44.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.43.0...v1.44.0) #### What's Changed - feat: Add slice Splice an element or multiple elements at index i. by [@​wenlingang](https://togithub.com/wenlingang) in [https://github.com/samber/lo/pull/371](https://togithub.com/samber/lo/pull/371) - feat: Make Filter() preserve type. by [@​FGasper](https://togithub.com/FGasper) in [https://github.com/samber/lo/pull/365](https://togithub.com/samber/lo/pull/365) - feat: Added DropByIndex helper for slice by [@​phith0n](https://togithub.com/phith0n) in [https://github.com/samber/lo/pull/398](https://togithub.com/samber/lo/pull/398) - feat: upgrade to math/rand/v2 by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/483](https://togithub.com/samber/lo/pull/483) - chore: remove `golang.org/x/exp` since it doesn't follow go 1 compatibility promise by [@​trim21](https://togithub.com/trim21) in [https://github.com/samber/lo/pull/478](https://togithub.com/samber/lo/pull/478) #### New Contributors - [@​wenlingang](https://togithub.com/wenlingang) made their first contribution in [https://github.com/samber/lo/pull/371](https://togithub.com/samber/lo/pull/371) - [@​jason-zhj](https://togithub.com/jason-zhj) made their first contribution in [https://github.com/samber/lo/pull/376](https://togithub.com/samber/lo/pull/376) - [@​FGasper](https://togithub.com/FGasper) made their first contribution in [https://github.com/samber/lo/pull/365](https://togithub.com/samber/lo/pull/365) - [@​phith0n](https://togithub.com/phith0n) made their first contribution in [https://github.com/samber/lo/pull/398](https://togithub.com/samber/lo/pull/398) **Full Changelog**: samber/lo@v1.43.0...v1.44.0 ### [`v1.43.0`](https://togithub.com/samber/lo/releases/tag/v1.43.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.42.0...v1.43.0) #### What's Changed - feat: adding HasKey by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/477](https://togithub.com/samber/lo/pull/477) - feat: adding lo.WaitFor by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/269](https://togithub.com/samber/lo/pull/269) - improvement: Optimize the performance of union method, avoid repeated expansion by [@​cwb2819259](https://togithub.com/cwb2819259) in [https://github.com/samber/lo/pull/397](https://togithub.com/samber/lo/pull/397) #### New Contributors - [@​cwb2819259](https://togithub.com/cwb2819259) made their first contribution in [https://github.com/samber/lo/pull/397](https://togithub.com/samber/lo/pull/397) **Full Changelog**: samber/lo@v1.42.0...v1.43.0 ### [`v1.42.0`](https://togithub.com/samber/lo/releases/tag/v1.42.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.41.0...v1.42.0) #### What's Changed - feat: add Nil by [@​gubtos](https://togithub.com/gubtos) in [https://github.com/samber/lo/pull/383](https://togithub.com/samber/lo/pull/383) - feat: Add First and FirstOrZeroValue functions by [@​Alireza-Kiani](https://togithub.com/Alireza-Kiani) in [https://github.com/samber/lo/pull/451](https://togithub.com/samber/lo/pull/451) - feat: adding LastOrEmpty and LastOr by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/474](https://togithub.com/samber/lo/pull/474) - feat: Feature/contains iterate by index by [@​lennon-guan](https://togithub.com/lennon-guan) in [https://github.com/samber/lo/pull/428](https://togithub.com/samber/lo/pull/428) - feat: speed up loops by reducing allocations by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/475](https://togithub.com/samber/lo/pull/475) - doc: inconsistent expression in README.md by [@​rolancia](https://togithub.com/rolancia) in [https://github.com/samber/lo/pull/406](https://togithub.com/samber/lo/pull/406) #### New Contributors - [@​gubtos](https://togithub.com/gubtos) made their first contribution in [https://github.com/samber/lo/pull/383](https://togithub.com/samber/lo/pull/383) - [@​Alireza-Kiani](https://togithub.com/Alireza-Kiani) made their first contribution in [https://github.com/samber/lo/pull/451](https://togithub.com/samber/lo/pull/451) - [@​rolancia](https://togithub.com/rolancia) made their first contribution in [https://github.com/samber/lo/pull/406](https://togithub.com/samber/lo/pull/406) - [@​lennon-guan](https://togithub.com/lennon-guan) made their first contribution in [https://github.com/samber/lo/pull/428](https://togithub.com/samber/lo/pull/428) **Full Changelog**: samber/lo@v1.41.0...v1.42.0 ### [`v1.41.0`](https://togithub.com/samber/lo/releases/tag/v1.41.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.40.0...v1.41.0) #### What's Changed - feat: adding Elipse by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/470](https://togithub.com/samber/lo/pull/470) - feat: adding CoalesceOrEmpty by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/469](https://togithub.com/samber/lo/pull/469) - feat: adding Earliest and Latest by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/468](https://togithub.com/samber/lo/pull/468) - feat: adding duration by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/471](https://togithub.com/samber/lo/pull/471) - feat: adding FilterReject by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/472](https://togithub.com/samber/lo/pull/472) - feat: adding RejectMap by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/473](https://togithub.com/samber/lo/pull/473) **Full Changelog**: samber/lo@v1.34.0...v1.41.0 ### [`v1.40.0`](https://togithub.com/samber/lo/releases/tag/v1.40.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.39.0...v1.40.0) #### What's Changed ##### Improvements - Use map indexing to speed up PickByKeys and OmitByKeys by [@​ericleb010](https://togithub.com/ericleb010) in [https://github.com/samber/lo/pull/447](https://togithub.com/samber/lo/pull/447) - ToSlicePtr: reduce allocations and improving speed by [@​yanmhlv](https://togithub.com/yanmhlv) in [https://github.com/samber/lo/pull/465](https://togithub.com/samber/lo/pull/465) - Feat: Adding zipby + unzipby by [@​samber](https://togithub.com/samber) in [https://github.com/samber/lo/pull/449](https://togithub.com/samber/lo/pull/449) - feat: add string conversion functions by [@​eiixy](https://togithub.com/eiixy) in [https://github.com/samber/lo/pull/466](https://togithub.com/samber/lo/pull/466) - Adding Mean and MeanBy by [@​usman1100](https://togithub.com/usman1100) in [https://github.com/samber/lo/pull/414](https://togithub.com/samber/lo/pull/414) ##### Doc & style - Fix typos by [@​szepeviktor](https://togithub.com/szepeviktor) in [https://github.com/samber/lo/pull/384](https://togithub.com/samber/lo/pull/384) - fix: instantiate typo by [@​testwill](https://togithub.com/testwill) in [https://github.com/samber/lo/pull/374](https://togithub.com/samber/lo/pull/374) - Fix typo in README.md by [@​eltociear](https://togithub.com/eltociear) in [https://github.com/samber/lo/pull/369](https://togithub.com/samber/lo/pull/369) - docs: update description for FindOrElse by [@​slomek](https://togithub.com/slomek) in [https://github.com/samber/lo/pull/370](https://togithub.com/samber/lo/pull/370) - style: no extra any type parameter by [@​d-enk](https://togithub.com/d-enk) in [https://github.com/samber/lo/pull/429](https://togithub.com/samber/lo/pull/429) - Fix IsNil link for pkg.go.dev by [@​invzhi](https://togithub.com/invzhi) in [https://github.com/samber/lo/pull/418](https://togithub.com/samber/lo/pull/418) - Docs: should use type int64 for lo.FlatMap in example by [@​apriil15](https://togithub.com/apriil15) in [https://github.com/samber/lo/pull/435](https://togithub.com/samber/lo/pull/435) ##### CI - CI: tests on multi go versions by [@​jiro4989](https://togithub.com/jiro4989) in [https://github.com/samber/lo/pull/445](https://togithub.com/samber/lo/pull/445) #### New Contributors - [@​szepeviktor](https://togithub.com/szepeviktor) made their first contribution in [https://github.com/samber/lo/pull/384](https://togithub.com/samber/lo/pull/384) - [@​testwill](https://togithub.com/testwill) made their first contribution in [https://github.com/samber/lo/pull/374](https://togithub.com/samber/lo/pull/374) - [@​eltociear](https://togithub.com/eltociear) made their first contribution in [https://github.com/samber/lo/pull/369](https://togithub.com/samber/lo/pull/369) - [@​slomek](https://togithub.com/slomek) made their first contribution in [https://github.com/samber/lo/pull/370](https://togithub.com/samber/lo/pull/370) - [@​ericleb010](https://togithub.com/ericleb010) made their first contribution in [https://github.com/samber/lo/pull/447](https://togithub.com/samber/lo/pull/447) - [@​yanmhlv](https://togithub.com/yanmhlv) made their first contribution in [https://github.com/samber/lo/pull/465](https://togithub.com/samber/lo/pull/465) - [@​eiixy](https://togithub.com/eiixy) made their first contribution in [https://github.com/samber/lo/pull/466](https://togithub.com/samber/lo/pull/466) - [@​jiro4989](https://togithub.com/jiro4989) made their first contribution in [https://github.com/samber/lo/pull/445](https://togithub.com/samber/lo/pull/445) - [@​d-enk](https://togithub.com/d-enk) made their first contribution in [https://github.com/samber/lo/pull/429](https://togithub.com/samber/lo/pull/429) - [@​usman1100](https://togithub.com/usman1100) made their first contribution in [https://github.com/samber/lo/pull/414](https://togithub.com/samber/lo/pull/414) - [@​invzhi](https://togithub.com/invzhi) made their first contribution in [https://github.com/samber/lo/pull/418](https://togithub.com/samber/lo/pull/418) - [@​apriil15](https://togithub.com/apriil15) made their first contribution in [https://github.com/samber/lo/pull/435](https://togithub.com/samber/lo/pull/435) **Full Changelog**: samber/lo@v1.39.0...v1.40.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding two new functions to
find.gofor fetching the first element of the slice.