Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additionalProperties in Claude and Llama. #91

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

samchon
Copy link
Owner

@samchon samchon commented Nov 28, 2024

They are possible to utilize the dynamic key typed object. Therefore, allowed additionalProperties in below types. "OpenAI ChatGPT" and "Google Gemini" blocks it.

  • IClaudeSchema
  • ILlamaSchema
  • ILlmSchemaV3
  • ILlmSchemaV3_1

This pull request includes changes to multiple JSON files and schemas to update the structure and remove unnecessary properties. The most significant changes involve adding new input data and modifying the schema definitions to allow additional properties.

Input Data Additions:

  • Added new input data in claude.additionalProperties.input.json and llama.additionalProperties.input.json to include the name, age, and additional properties for a person. [1] [2]

Schema Updates:

  • Added new schema definitions in claude.additionalProperties.schema.json and llama.additionalProperties.schema.json to define the structure for the new input data, including properties for name, age, and additional information. [1] [2]
  • Removed additionalProperties constraints across various sections in claude.sale.schema.json and llama.sale.schema.json to allow for more flexible data structures. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Data Adjustments:

  • Updated the claude.sale.input.json file to modify the naming convention for Surface Pro 9 models and adjust the tags list. [1] [2] [3] [4] [5] [6] [7] [8]

They are possible to utilize the dynamic key typed object. Therefore, allowed `additionalProperties` in below types. "OpenAI ChatGPT" and "Google Gemini" blocks it.

  - `IClaudeSchema`
  - `ILlamaSchema`
  - `ILlmSchemaV3`
  - `ILlmSchemaV3_1`
@samchon samchon added the enhancement New feature or request label Nov 28, 2024
@samchon samchon self-assigned this Nov 28, 2024
Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, no problem.

@samchon samchon merged commit 93942ef into master Nov 28, 2024
4 checks passed
@samchon samchon deleted the feat/additionalProperties branch November 28, 2024 05:49
samchon added a commit to samchon/typia that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant