From 9960973d2341ff4b96b5e2e5eeb7c7e834754335 Mon Sep 17 00:00:00 2001 From: Tyler Crocker Date: Sat, 16 Apr 2022 13:53:16 -0700 Subject: [PATCH 1/2] dropping URI.escape for Addressable::URI.parse as the former is no longer supported --- lib/isbndb/api_client.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/isbndb/api_client.rb b/lib/isbndb/api_client.rb index 58d9ccd..237e317 100644 --- a/lib/isbndb/api_client.rb +++ b/lib/isbndb/api_client.rb @@ -11,7 +11,7 @@ def initialize(api_key: nil) end def request(page, params = {}) - response = self.class.get(URI.escape(page), query: params, headers: headers, timeout: 60) + response = self.class.get(Addressable::URI.parse(page), query: params, headers: headers, timeout: 60) raise ISBNdb::RequestError.new "HTTP Response: #{response.code}" if response.code != 200 begin self.class.snakify(response.parsed_response) From 2aaeb644614447c00bd418ea063745b0fbd6e836 Mon Sep 17 00:00:00 2001 From: Tyler Crocker Date: Sat, 16 Apr 2022 14:44:27 -0700 Subject: [PATCH 2/2] woops, encode, note parse --- lib/isbndb/api_client.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/isbndb/api_client.rb b/lib/isbndb/api_client.rb index 237e317..a630b4f 100644 --- a/lib/isbndb/api_client.rb +++ b/lib/isbndb/api_client.rb @@ -11,7 +11,7 @@ def initialize(api_key: nil) end def request(page, params = {}) - response = self.class.get(Addressable::URI.parse(page), query: params, headers: headers, timeout: 60) + response = self.class.get(Addressable::URI.encode(page), query: params, headers: headers, timeout: 60) raise ISBNdb::RequestError.new "HTTP Response: #{response.code}" if response.code != 200 begin self.class.snakify(response.parsed_response)