Make bcf_remove_allele_set() set work on unpacked records #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviesrob
reviewed
Nov 10, 2021
vcfutils.c
Outdated
| @@ -256,10 +256,10 @@ int bcf_remove_allele_set(const bcf_hdr_t *header, bcf1_t *line, const struct kb | |||
| int *map = (int*) calloc(line->n_allele, sizeof(int)); | |||
| uint8_t *dat = NULL; | |||
|
|
|||
| bcf_unpack(line, BCF_UN_FMT); | |||
There was a problem hiding this comment.
Should this be BCF_UN_ALL? Looking at bcf_unpack(), BCF_UN_FMT will only unpack the indiv data, but this needs to also access info and allele.
There was a problem hiding this comment.
This is now replaced with the correct BCF_UN_ALL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1353