Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio player creates a vertical scroll-bar in embeds #705

Closed
1 task done
Dananji opened this issue Nov 1, 2024 · 4 comments
Closed
1 task done

Audio player creates a vertical scroll-bar in embeds #705

Dananji opened this issue Nov 1, 2024 · 4 comments
Assignees
Labels
bug 🐛 Something isn't working player Changes/fixes in player component

Comments

@Dananji
Copy link
Collaborator

Dananji commented Nov 1, 2024

Description

Audio player's height is 60px while the iframe height in Avalon embeds are set to 40px. This creates a vertical scroll-bar in the iframe.
Screenshot 2024-11-01 at 1 32 21 PM

Done Looks Like

  • Audio player should be contained within the iframe without overflow
@Dananji Dananji added bug 🐛 Something isn't working player Changes/fixes in player component labels Nov 1, 2024
@elynema
Copy link

elynema commented Nov 1, 2024

@Dananji I'm tagging this as 8.0 and moving it to Needs Refinement. Do we need to discuss potential solutions, or is it ready to work?

@Dananji
Copy link
Collaborator Author

Dananji commented Nov 1, 2024

Yes, I think we need a discussion for this.

@joncameron
Copy link
Contributor

2 solutions:

  • change the iframe height and see if we can edit embeds in place with a new height value (first thing to try)
    • possible to use JS to adjust element height?
  • pull the progress bar down again, perhaps encountering zoom issues again

@elynema
Copy link

elynema commented Nov 7, 2024

Dananji was not able to find a solution that would increase the size of the embed and also update existing embeds, so she pulled the progress bar back down inline with the other widgets like before in the embed context only. Because there are fewer widgets in this, zoom works better.

audio quality and playback widgets and zoom scrubber are not included in the embed because they pop up menus that don't have space in this context.

@elynema elynema closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working player Changes/fixes in player component
Projects
None yet
Development

No branches or pull requests

3 participants