Remove the explicit superclass from monkey-patch #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the monkey-patch to work with either rdf <= 3.2.4 or rdf >= 3.2.5 The monkey-patch is necessary to maintain the current behavior of nanosecond precision in dates Failing tests in hyrax revealed this so tests were added here to test this functionality
elrayle
approved these changes
Mar 4, 2022
| it 'time zone must have semicolin to be a cannonical XMLSchema#dateTime' do | ||
| expect(triple.to_s).to match(/\+01:00/) | ||
| end | ||
|
|
||
| context 'nanoseconds' do |
There was a problem hiding this comment.
Nice coverage of possible conditions.
| # TODO: Figure out how to contribute something upstream to avoid monkey-patching | ||
| module RDF | ||
| class Literal | ||
| class DateTime |
There was a problem hiding this comment.
Glad to see the suggestion to remove < Literal worked.
|
I'm running hyrax's tests against this branch: samvera/hyrax#5495 |
|
All of Hyrax's tests passed and I verified that the build was using rdf 3.2.5 for the ruby 2.6 and 2.7 builds and rdf < 3.2 for the ruby 2.5 build. |
|
Sorry, this doesn't fix #1471 quite yet, but when this gets into a release I'll work on backporting it and doing a 12.x release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1466 an d #1471
This allows the monkey-patch to work with either rdf <= 3.2.4 or rdf >= 3.2.5
The monkey-patch is necessary to maintain the current behavior of nanosecond precision in dates
Failing tests in hyrax revealed this so tests were added here to test this functionality
Note that rdf 3.2.0+ require ruby >= 2.6 so the ruby 2.5 circleci builds should be testing with rdf < 3.2.5 while the ruby 2.6 and 2.7 builds should be testing with rdf = 3.2.5.