accurate-relationship-forming #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sephirothkod
approved these changes
Apr 7, 2022
alishaevn
commented
Apr 8, 2022
| @@ -152,7 +153,7 @@ def update_collection(attrs) | |||
|
|
|||
| # This method is heavily inspired by Hyrax's AttachFilesToWorkJob | |||
| def create_file_set(attrs) | |||
| work = find_record(attributes[related_parents_parsed_mapping].first) | |||
| _, work = find_record(attributes[related_parents_parsed_mapping].first, importer_run_id) | |||
There was a problem hiding this comment.
find_record now returns two values, but we don't need the entry here
alishaevn
commented
Apr 8, 2022
| @@ -37,11 +37,11 @@ def perform(parent_identifier:, importer_run_id:) | |||
| end.sort_by(&:order) | |||
|
|
|||
| @importer_run_id = importer_run_id | |||
| @parent_record = find_record(parent_identifier) | |||
| @parent_entry, @parent_record = find_record(parent_identifier, importer_run_id) | |||
There was a problem hiding this comment.
example use case that made this necessary:
a collection was imported in importer 1, and in importer 2 we are importing a work to add to that collection. in that case, line 56 below would have failed because this importer_run doesn't have the collection.
alishaevn
commented
Apr 8, 2022
| @@ -63,7 +66,8 @@ def check_parent_is_a_work!(parent_identifier) | |||
| end | |||
|
|
|||
| def find_parent_record(parent_identifier) | |||
| @parent_record ||= find_record(parent_identifier) | |||
| @parent_record ||= find_record(parent_identifier, importer_run_id) | |||
There was a problem hiding this comment.
I tried calling .last on this method but it didn't work.
alishaevn
changed the title
alishaevn
changed the title
ShanaLMoore
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use case
I imported the same collection on 3 different importers while upgrading bl. the first time the collection wasn't created. so on the 3rd importer where the collection had been created, it was still finding the entry from the first importer. and therefore
entry.factory.findwas nil when it shouldn't have been.expected behavior
find_recorddemo