Erroneous pending status on import #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alishaevn
reviewed
May 20, 2022
| @@ -38,7 +38,7 @@ | |||
| <% @importers.each do |importer| %> | |||
| <tr> | |||
| <th scope="row"><%= link_to importer.name, importer_path(importer) %></th> | |||
| <td><%= importer.status %></td> | |||
| <td><%= importer.last_run&.enqueued_records&.zero? ? 'Complete' : importer.status %></td> | |||
There was a problem hiding this comment.
is this still needed now that record_status is being called on collection entries?
alishaevn
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#record_statuswhich updates the status wasn't being called when a collection finishes however it was called when a work was completed.This seemingly meant that if the works finish faster than the collections the status gets stuck on "Pending".