Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving OAI metadata capture to entry processing #697

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Dec 22, 2022

In writing #694 I introduced an OAI bug. There are two OAI fetch cycles.

The first is the list of records. These are fetched via the list_identifiers method. That method returns header information without metadata. Then, we submit one job per header. At that point we perform the second fetch of the record. This includes the full metadata.

In writing #694 I introduced an OAI bug.  There are two OAI fetch
cycles.

The first is the list of records.  These are fetched via the
`list_identifiers` method.  That method returns header information
without metadata.  Then, we submit one job per header.  At that point we
perform the second fetch of the record.  This includes the full
metadata.
@jeremyf jeremyf added patch-ver for release notes bug-fix labels Dec 22, 2022
Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, glad you found it and applied the fix!

@jeremyf jeremyf merged commit b857a25 into main Dec 22, 2022
@jeremyf jeremyf deleted the jeremyf-fixing-raw-metadata-capture branch December 22, 2022 14:51
jeremyf added a commit to scientist-softserv/adventist-dl that referenced this pull request Dec 22, 2022
> Moving OAI metadata capture to entry processing
>
> In writing samvera/bulkrax#694 I introduced an OAI bug.  There
> are two OAI fetch cycles.
>
>The first is the list of records.  These are fetched via the
>`list_identifiers` method.  That method returns header information
>without metadata.  Then, we submit one job per header.  At that point
>we perform the second fetch of the record.  This includes the full
>metadata.

Related to:

- samvera/bulkrax#697
- samvera/bulkrax#694
- #211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants