Adding ApplicationParser#file_set_entry_class to API #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, this method was not defined on the `ApplicationParser` yet there was an assumption in the `Bulkrax::ImportersController` and `Bulkrax::ExportersController` that this method existed. With this commit, we're acknowledging that each parser should implement this method. In addition this commit adds a `#create_file_sets` method for the `Bulkrax::XmlParser`. This change mirrors the `Bulkrax::XmlParser#create_collections` implementation and todo item. A future state that would be wonderful is to create spec helpers that implementers could use in their specs to ensure a compliant interface. This echoes how Valkyrie does things.
alishaevn
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, this method was not defined on the
ApplicationParseryet there was an assumption in theBulkrax::ImportersControllerandBulkrax::ExportersControllerthat this method existed.With this commit, we're acknowledging that each parser should implement this method.
In addition this commit adds a
#create_file_setsmethod for theBulkrax::XmlParser. This change mirrors theBulkrax::XmlParser#create_collectionsimplementation and todo item.A future state that would be wonderful is to create spec helpers that implementers could use in their specs to ensure a compliant interface. This echoes how Valkyrie does things.