Expanding Bulkrax::EntrySpecHelper to handle collections
#742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
added
patch-ver
Prior to this, you couldn't specify the type of entry you wanted to test (only the :entry_class). With this change, you can specify which type you want to test.
jeremyf
force-pushed
the
improving-entry-spec-handler
branch
from
aa5959d
to
0d96daf
Compare
alishaevn
requested changes
Feb 16, 2023
Co-authored-by: Alisha Evans <alisha@notch8.com>
alishaevn
approved these changes
Feb 17, 2023
alishaevn
requested changes
Feb 17, 2023
Co-authored-by: Alisha Evans <alisha@notch8.com>
alishaevn
approved these changes
Feb 17, 2023
jeremyf
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Oct 4, 2023
This commit includes two things: 1. Favor Bulkrax::EntrySpecHelper provided by Bulkrax (for which the removed code was a prototype). 2. Use the existing spec to determine what the default work type should be (instead of relying on a random assignment based on the first element of the registered curation concerns) And from this commit, we have a passing test! Related to: - https://github.com/scientist-softserv/adventist-dl/issues/538 - samvera/bulkrax#726 - samvera/bulkrax#719 - samvera/bulkrax#742 - samvera/hyku#1811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, you couldn't specify the type of entry you wanted to test (only the :entry_class). With this change, you can specify which type you want to test.