find existing records more often, leading to better round tripping experiance #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkiahstroud
reviewed
Aug 16, 2023
| @@ -102,7 +103,8 @@ def find_or_create | |||
| end | |||
|
|
|||
| def search_by_identifier | |||
| query = { work_identifier => | |||
| work_index = ::ActiveFedora.index_field_mapper.solr_name(work_identifier, :facetable) | |||
There was a problem hiding this comment.
- Will
work_identifieralways be:facetable? Is there a chance this will different project-to-project, and thus fail sometimes? - Is there a simple way to achieve this without calling
ActiveFedoradirectly? With Valkyrization on the horizon, usingActiveFedoradirectly is going the way of the dinosaur. If the answer is "no" that's fine, I don't think it should block this PR; this ticket will rework this line later
There was a problem hiding this comment.
I think the answer with both is to add a new config variable to bulkrax with a default that just is "#{work_identifier}_ssim" and this should be a new ticket for later work
There was a problem hiding this comment.
I'm reverting this change because it's breaking my ability to import FileSet's using the row.
ref: #867
alishaevn
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveFedora use to find objects with {field => value}. Now it only reliably works with {solr_name(field) => value} so we use that instead. Also if find by id fails we should still check source_identifier to see if we can find it that way.