Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use find_by_source_identifier instead of find_by_bulkrax_identifier #907

Merged
merged 7 commits into from
Feb 1, 2024

Commits on Jan 29, 2024

  1. i903 - move bulkrax identifier custom queries into bulkrax

    move bulkrax identifier custom queries into bulkrax
    
    Issue:
    - scientist-softserv/hykuup_knapsack#136
    ShanaLMoore committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    6075930 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. make find_by_source_identifier dynamic

    Import a csv with child works. The forming of relationships is not working. Part of the problem is the find_by_bulkrax_identifier call.
    
    From GBH, this used to be find_by_bulkrax_identifier which not all clients will configure as their source identifier. Instead we need to ask for the source identifier and use that for the sql query. This commit goes along with a PR from Hyku which currently has the find_by_source_identifier.rb files defined.
    
    Issue:
    - scientist-softserv/hykuup_knapsack#128
    
    Co-Authored-By: Kirk Wang <k3wang@gmail.com>
    ShanaLMoore and kirkkwang committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    78e677b View commit details
    Browse the repository at this point in the history
  2. remove files: they live in Hyku for now

    Co-Authored-By: Kirk Wang <k3wang@gmail.com>
    ShanaLMoore and kirkkwang committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ff02e13 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    29f2264 View commit details
    Browse the repository at this point in the history
  4. 🧹 remove misleading comment

    Co-Authored-By: Kirk Wang <k3wang@gmail.com>
    ShanaLMoore and kirkkwang committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    9ad140f View commit details
    Browse the repository at this point in the history
  5. 🧹 Entry is a required argument when initializing ObjectFactory

    Fix for broken specs
    
    Co-Authored-By: Kirk Wang <k3wang@gmail.com>
    ShanaLMoore and kirkkwang committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5fc4962 View commit details
    Browse the repository at this point in the history
  6. revert changes to pass Entry arg

    The object factory already has work_identifier: parser.work_identifier. we don't need the entry argument after all.
    
    ref:
    - https://github.com/samvera/bulkrax/blob/main/app/models/concerns/bulkrax/import_behavior.rb#L181
    
    Co-Authored-By: Kirk Wang <k3wang@gmail.com>
    ShanaLMoore and kirkkwang committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    6d09235 View commit details
    Browse the repository at this point in the history