Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Importer Index and Show Entries With Search, Filtering, Sort and More #914

Conversation

orangewolf
Copy link
Member

@orangewolf orangewolf commented Feb 8, 2024

Datatables is already used in Hyrax and elsewhere in Bulkrax. This connects it via Ajax and consolidates the 3 object type tables down in to one easy to use grid.

This change is only breaking if you have overridden the importer show page.

Demo Video

@orangewolf orangewolf force-pushed the one_table_to_rule_them_all_one_table_to_find_them_one_table_to_bring_them_all branch from f871a9d to 9c9f3e3 Compare February 8, 2024 09:16
@orangewolf orangewolf added breaking-change for release notes minor-ver for release notes and removed breaking-change for release notes labels Feb 8, 2024
Copy link
Contributor

@jeremyf jeremyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ./app/views/bulkrax/exporters/show.html.erb also renders the shared/_entries_tab partial and the change to the shared/_entries_tab appears to break how the exporter's rendering of that tab.

jeremyf and others added 14 commits February 8, 2024 09:36
…_them_one_table_to_bring_them_all

* main:
  Denormalize Status Message to that Entry Look Up Can Be Fast (#913)
  ⚙️ Adding dry-monads as development dependency
This change will make the search query cross database compatible.
…all_one_table_to_find_them_one_table_to_bring_them_all
…able_to_bring_them_all' of github.com:samvera/bulkrax into one_table_to_rule_them_all_one_table_to_find_them_one_table_to_bring_them_all
@orangewolf orangewolf changed the title Update Importer Show Entries With Search, Filtering, Sort and More Update Importer Index and Show Entries With Search, Filtering, Sort and More Feb 9, 2024
@orangewolf
Copy link
Member Author

The ./app/views/bulkrax/exporters/show.html.erb also renders the shared/_entries_tab partial and the change to the shared/_entries_tab appears to break how the exporter's rendering of that tab.

this is being fixed in a seperate pr that's coming in hot

@orangewolf orangewolf merged commit 0e822f5 into main Feb 10, 2024
6 checks passed
@orangewolf orangewolf deleted the one_table_to_rule_them_all_one_table_to_find_them_one_table_to_bring_them_all branch February 10, 2024 01:31
jeremyf added a commit that referenced this pull request Feb 23, 2024
* main:
  ♻️ Favor member_ids_ssim over file_set_ids_ssim (#929)
  🐛 Fix exporter page for Bootstrap 3 applications (#928)
  ♻️ Favor configuration over hard-coding (#927)
  Fix exporters show page - 2 (#926)
  Redo records with the remove_and_rerun property in the data, move individual remove and rerun to a background job (#923)
  Mark records as skipped if we do not see them during an import run (#922)
  For every importer / record combo there should be exactly one entry (#921)
  Add Skip to the datatabels (#920)
  Update Importer Index and Show Entries With Search, Filtering, Sort and More (#914)
  Restore rails5 support (#919)
  Strip out all special characters from csv headers (#918)
  Need to Include dry/monads in sample app to get generators working (#917)
  Found another place we need to include the monad lib. This time so that generators work
  Denormalize Status Message to that Entry Look Up Can Be Fast (#913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants