Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exporters show page - 2 #926

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Fix exporters show page - 2 #926

merged 6 commits into from
Feb 10, 2024

Conversation

orangewolf
Copy link
Member

exporters

Mimicking the importers show page, this change adds support for the datatables.js to the exporters show page.

kirkkwang and others added 5 commits February 9, 2024 18:08
Mimicking the importers show page, this change adds support for the
datatables.js to the exporters show page.
Co-authored-by: Rob Kaufman <rob@notch8.com>
Co-authored-by: Rob Kaufman <rob@notch8.com>
In this commit, we pass the the @importer or @Exporter to the
entries_tab partial so we don't need any clever/brittle tricks to
determine the type of the current importer/exporter.

Also, we fix some names.
@kirkkwang kirkkwang added the patch-ver for release notes label Feb 10, 2024
This commit will add the same style of datatables from the importer
index page.
@orangewolf orangewolf merged commit bf0628b into main Feb 10, 2024
6 checks passed
@orangewolf orangewolf deleted the exporter-branch-fix branch February 10, 2024 06:57
jeremyf added a commit that referenced this pull request Feb 23, 2024
* main:
  ♻️ Favor member_ids_ssim over file_set_ids_ssim (#929)
  🐛 Fix exporter page for Bootstrap 3 applications (#928)
  ♻️ Favor configuration over hard-coding (#927)
  Fix exporters show page - 2 (#926)
  Redo records with the remove_and_rerun property in the data, move individual remove and rerun to a background job (#923)
  Mark records as skipped if we do not see them during an import run (#922)
  For every importer / record combo there should be exactly one entry (#921)
  Add Skip to the datatabels (#920)
  Update Importer Index and Show Entries With Search, Filtering, Sort and More (#914)
  Restore rails5 support (#919)
  Strip out all special characters from csv headers (#918)
  Need to Include dry/monads in sample app to get generators working (#917)
  Found another place we need to include the monad lib. This time so that generators work
  Denormalize Status Message to that Entry Look Up Can Be Fast (#913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants