♻️ Favor configuration over hard-coding #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that Hyrax provides a mechanism for specifying a queue name, we should echo that configuration, but also provide our own configuration as well as the same fallback.
jeremyf
added
minor-ver
bkiahstroud
approved these changes
Feb 14, 2024
jeremyf
added a commit
that referenced
this pull request
Feb 23, 2024
* main: ♻️ Favor member_ids_ssim over file_set_ids_ssim (#929) 🐛 Fix exporter page for Bootstrap 3 applications (#928) ♻️ Favor configuration over hard-coding (#927) Fix exporters show page - 2 (#926) Redo records with the remove_and_rerun property in the data, move individual remove and rerun to a background job (#923) Mark records as skipped if we do not see them during an import run (#922) For every importer / record combo there should be exactly one entry (#921) Add Skip to the datatabels (#920) Update Importer Index and Show Entries With Search, Filtering, Sort and More (#914) Restore rails5 support (#919) Strip out all special characters from csv headers (#918) Need to Include dry/monads in sample app to get generators working (#917) Found another place we need to include the monad lib. This time so that generators work Denormalize Status Message to that Entry Look Up Can Be Fast (#913)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that Hyrax provides a mechanism for specifying a queue name, we should echo that configuration, but also provide our own configuration as well as the same fallback.