🐛 Fix FileSet csv rows for AF imports #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will fix the functionality for adding a FileSet row in the CSV to add additional metadata to FileSets. The problem was located in `Bulkrax::ObjectFactory#create_file_set`. When it tries to find a record, it actually comes back as a `FalseClass` because of the new logic introduced recently which breaks further down. If we add raise an error in our `Bulkrax::ImportFileSetJob#find_parent_record` which is at a higher point than before, then we can requeue the job and check again. If the parent record is created by then, we will execute the rest of the job.
|
Relevant ticket: scientist-softserv/hykuup_knapsack#216 @kirkkwang could you attach the sample csv for QA purposes? |
ShanaLMoore
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit will fix the functionality for adding a FileSet row in the CSV to add additional metadata to FileSets. The problem was located in
Bulkrax::ObjectFactory#create_file_set. When it tries to find a record, it actually comes back as aFalseClassbecause of the new logic introduced recently which breaks further down. If we add raise an error in ourBulkrax::ImportFileSetJob#find_parent_recordwhich is at a higher point than before, then we can requeue the job and check again. If the parent record is created by then, we will execute the rest of the job.Issue:
Screenshots
Testing Instructions
This fix was made in the PALs repo, here is the CSV used:
pals-with-file-row.zip