Delete and redo file sets #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
previously approved these changes
Jun 21, 2024
ShanaLMoore
reviewed
Jun 21, 2024
| @@ -2,4 +2,22 @@ | |||
|
|
|||
| module Bulkrax | |||
| class DeleteFileSetJob < DeleteJob; end | |||
|
|
|||
| def perform(entry, importer_run) | |||
There was a problem hiding this comment.
Do you need to pass the importer_run? It doesn't seem like it's getting used here.
There was a problem hiding this comment.
its used in the parent job (so the call to super gets it)
ShanaLMoore
reviewed
Jun 21, 2024
| @@ -2,4 +2,22 @@ | |||
|
|
|||
| module Bulkrax | |||
| class DeleteFileSetJob < DeleteJob; end | |||
There was a problem hiding this comment.
Also, ignore me if I'm reading this wrong, but is this an extra end?
There was a problem hiding this comment.
grr - I really hate the ; end syntax. it takes an important thing and hides it for no real gain but to save a linefeed. fixed
There was a problem hiding this comment.
this was a really good catch Shana. its legal to define the method on the module so its syntaxitcally correct but would not have ever been called the way I had it
ShanaLMoore
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.